fix(upgrade): pass correct values to ngOnChanges for interpolation bindings
#14301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
comp: upgrade/dynamic
action: review
petebacondarwin
approved these changes
Feb 4, 2017
| @@ -78,17 +78,15 @@ export class DowngradeComponentAdapter { | |||
| let expr: any /** TODO #9100 */ = null; | |||
|
|
|||
| if (attrs.hasOwnProperty(input.attr)) { | |||
| const observeFn = ((prop: any /** TODO #9100 */) => { | |||
| const observeFn = (prop => { | |||
There was a problem hiding this comment.
Does the linter let you get away with an implicit any here?
There was a problem hiding this comment.
It infers it is a string (because input.prop is a string). No idea if/why it didn't before.
…bindings Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions).
gkalpak
force-pushed
the
fix-upgrade-correct-values-for-changes
branch
from
ac17c78
to
f5f3f8b
Compare
|
(Squashed the commits.) |
petebacondarwin
added
action: merge
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 7, 2017
…bindings (angular#14301) Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions). PR Close angular#14301
|
@gkalpak this does not rebase on 2.4.x, if you would like me to merge it please create a new PR against that branch. |
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 10, 2017
…bindings Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions). This is the same as angular#14301, but for the 2.4.x branch.
3 tasks
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 10, 2017
…bindings Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions). This is the same as angular#14301, but for the 2.4.x branch.
mhevery
pushed a commit
that referenced
this pull request
Feb 10, 2017
…bindings (#14400) Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions). This is the same as #14301, but for the 2.4.x branch.
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…bindings (angular#14301) Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions). PR Close angular#14301
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…bindings (angular#14301) Previously, the `previousValue` and `currentValue` arguments passed to the `SimpleChange` constructor were swapped for interpolation bindings. This commit also refactors the code, so that interpolation bindings and property bindings share the same implementation, and fixes some broken tests (that hide failures by allowing the `$exceptionHandler` to swallow thrown exceptions). PR Close angular#14301
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The
previousValueandcurrentValuearguments passed to theSimpleChangeconstructor are swapped for interpolation bindings.There are also some tests that may hide failures by allowing the
$exceptionHandlerto swallow thrown exceptions.What is the new behavior?
The
SimpleChangeobjects are created correctly.Interpolation bindings and property bindings share the same implementation.
The tests no longer hide failures by swallowing exceptions.
Does this PR introduce a breaking change? (check one with "x")