fix(compiler): check entry component metadata #14335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
reviewed
Feb 7, 2017
| @@ -949,6 +950,10 @@ export class CompileMetadataResolver { | |||
| return {componentType: dirType, componentFactory: dirSummary.componentFactory}; | |||
| } | |||
| } | |||
|
|
|||
| if (throwIfNotFound) { | |||
| throw new SyntaxError(`${dirType.name} is not an entry component.`); | |||
There was a problem hiding this comment.
Or ... can not be used as an entry component.
tbosch
reviewed
Feb 7, 2017
| .toThrowError(SyntaxError, `SimpleService is not an entry component.`); | ||
| })); | ||
|
|
||
| it(`should not throw an error when a Directive is added to module's bootstrap list`, |
There was a problem hiding this comment.
Actually it should throw in this case as well!
tbosch
reviewed
Feb 7, 2017
| if (entry) { | ||
| components.push(entry); | ||
| } | ||
| }); | ||
| return components; | ||
| } | ||
|
|
||
| private _getEntryComponentMetadata(dirType: any): cpl.CompileEntryComponentMetadata { | ||
| private _getEntryComponentMetadata(dirType: any, throwIfNotFound = true): | ||
| cpl.CompileEntryComponentMetadata { | ||
| const dirMeta = this.getNonNormalizedDirectiveMetadata(dirType); | ||
| if (dirMeta) { |
There was a problem hiding this comment.
check DirMeta.isComponent / dirSummary.isComponent to be truthy...
tbosch
added
the
action: cleanup
tbosch
approved these changes
Feb 7, 2017
bowenni
force-pushed
the
throw-an-error-if-no-component-metadata-found
branch
from
4869fd4
to
59ef923
Compare
Throw a proper error when a non-component is added to module's bootstrap list
bowenni
force-pushed
the
throw-an-error-if-no-component-metadata-found
branch
from
4f3524c
to
02130f6
Compare
|
@tbosch PTAL |
tbosch
removed
the
action: cleanup
mhevery
approved these changes
Feb 9, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 9, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 9, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 9, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a proper error when a non-component is added to module's bootstrap list.
This avoids adding non-components to entry components and avoids printing stack traces.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")