Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): allow absolute style urls #14365

Closed
wants to merge 1 commit into from

Conversation

DzmitryShylovich
Copy link
Contributor

Closes #4974

As specified by @tbosch #4974 (comment) :

Yes, this is a valid bug right now

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Feb 9, 2017
mhevery pushed a commit to mhevery/angular that referenced this pull request Feb 9, 2017
mhevery pushed a commit to mhevery/angular that referenced this pull request Feb 9, 2017
@mhevery mhevery closed this in 6b9aa2c Feb 9, 2017
@DzmitryShylovich DzmitryShylovich deleted the gh/4974 branch February 9, 2017 23:22
mhevery added a commit that referenced this pull request Feb 11, 2017
IgorMinar pushed a commit that referenced this pull request Feb 16, 2017
IgorMinar pushed a commit that referenced this pull request Feb 16, 2017
@ozrite
Copy link

ozrite commented Mar 10, 2017

Its still a bug even in 2017 even in latest version of angular with angular cli. The aboloute paths from within the global css files are not being read for custom font files.
//******************** Global includes **************************

<script type='text/javascript' src ='https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.3/jquery-ui.min.js'></script> <script type="text/javascript" src="js/script.js"></script> <script src="js/bootstrap.min.js"></script>

//****************************** css file from pins-styles.css ****************************
These paths are not being read.
//css file

@charset "UTF-8";

@font-face {
font-family: "pins";
src:url("../pins-fonts/pins.eot");
src:url("../pins-fonts/pins.eot?#iefix") format("embedded-opentype"),
url("../pins-fonts/pins.woff") format("woff"),
url("../pins-fonts/pins.ttf") format("truetype"),
url("../pins-fonts/pins.svg#pins") format("svg");
font-weight: normal;
font-style: normal;

}

I have ported my code to new version of angularCli but after troubleshooting many problems, i found out that the absolute paths are not working. rest of the styles are being loaded.

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styleUrls does not work with root path "/"
4 participants