ci: clean up logging and error handling on travis #14425

IgorMinar · 2017-02-11T17:45:33Z

No description provided.

IgorMinar · 2017-02-21T17:06:11Z

scripts/ci-lite/angular.sh

+fi
+
+
+RED='\033[0;31m'


@StephenFluin please make this even more awesome

alxhub · 2017-02-22T00:50:42Z

build.sh

+    ln -s ../../../../node_modules/angular/angular.js .
+    ln -s ../../../../bower_components/polymer .
+    ln -s ../../../../node_modules/incremental-dom/dist/incremental-dom-cjs.js
+    cd -


This works just as well, but I find pushd/popd a little more readable for things like this.

this is code I didn't want to touch because Jason is rewriting it. it can be much cleaner. I'll leave that for a followup pr

alxhub · 2017-02-22T01:07:53Z

parent.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash


Is this a test file?

yes. I'll remove this.

alxhub · 2017-02-22T01:11:55Z

scripts/ci-lite/_travis_fold.sh

+  # strip trailing "-"
+  sanitizedFoldName=${sanitizedFoldName%-}
+  local returnArrow="<===  ${foldName}  <==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<==<=="
+  # keep all messages consistently wide 80chars regardless of the foldName


100chars per the truncation, not 80.

alxhub · 2017-02-22T01:13:14Z

scripts/ci-lite/_travis_fold.sh

+
+
+
+#[0Ktravis_fold:start:install


Is this example syntax?

alxhub · 2017-02-22T01:14:52Z

scripts/ci-lite/deploy.sh

+  e2e)
+    travisFoldStart "deploy.packages"
+      ./scripts/publish/publish-build-artifacts.sh
+    travisFoldStart "deploy.packages"


travisFoldEnd?

good catch!

alxhub · 2017-02-22T01:20:32Z

scripts/ci-lite/test_saucelabs.sh

-echo 'travis_fold:end:test_saucelabs'
+travisFoldStart "test.unit.saucelabs"
+  ./scripts/sauce/sauce_connect_block.sh
+  SAUCE_ACCESS_KEY=`echo $SAUCE_ACCESS_KEY | rev`


Won't set -x print this out?

we need to check

gkalpak · 2017-02-22T10:32:40Z

scripts/ci-lite/test_js.sh


-echo 'travis_fold:end:test.unit.localChrome'
+travisFoldStart "test.unit.localChrome"


Not related to this PR, but any idea what localChrome refers to here?

it's a mode where we run our unit tests quickly on local chrome to verify that they pass. it give us faster response than SL/BS browsers

gkalpak · 2017-02-22T10:37:38Z

scripts/ci-lite/cleanup.sh

-cd ../..
-
+source ${TRAVIS_BUILD_DIR}/scripts/ci-lite/_travis_fold.sh
+source ${TRAVIS_BUILD_DIR}/scripts/ci-lite/env.sh


Won't the check of TRAVIS_TEST_RESULT in env.sh abort cleanup.sh in case of error?

gkalpak · 2017-02-22T10:43:59Z

scripts/ci-lite/_travis_fold.sh

+  echo ${enterArrow:0:100}
+  # turn on verbose mode so that we have better visibility into what's going on
+  # http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_02_03.html#table_02_01
+  set -x


Shouldn't this be restored to the state before calling travisFoldStart?

no, we actually want to turn on the xtrace at this point

gkalpak · 2017-02-22T10:44:31Z

scripts/ci-lite/_travis_fold.sh

+}
+
+function travisFoldEnd() {
+  set +x


Shouldn't the flag be restored at the end of the function?

nah. while possible, it's not trivial and in our case every travisFoldEnd is followed either by another travisFoldEnd or by travisFoldStart invocation

… error handling

usernamealreadyis · 2017-03-03T16:40:34Z

#9104

… error handling (angular#14425)

angular-automatic-lock-bot · 2019-09-10T23:21:15Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Feb 11, 2017

IgorMinar force-pushed the speed-up-ci branch 3 times, most recently from 315a162 to 5d3380f Compare February 12, 2017 04:59

IgorMinar force-pushed the speed-up-ci branch 4 times, most recently from 7173c27 to ba98493 Compare February 20, 2017 23:05

IgorMinar commented Feb 21, 2017

View reviewed changes

scripts/ci-lite/angular.sh

fi

RED='\033[0;31m'

Copy link

Contributor Author

IgorMinar Feb 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenFluin please make this even more awesome

alxhub approved these changes Feb 22, 2017

View reviewed changes

IgorMinar force-pushed the speed-up-ci branch from 1a5ef45 to 6ea5373 Compare February 22, 2017 07:01

gkalpak reviewed Feb 22, 2017

View reviewed changes

IgorMinar force-pushed the speed-up-ci branch 2 times, most recently from 3d42a5b to 79d5cad Compare February 22, 2017 11:08

IgorMinar changed the title ~~ci: clean up and speed up travis setup~~ ci: clean up logging on travis Feb 23, 2017

IgorMinar changed the title ~~ci: clean up logging on travis~~ ci: clean up logging and error handling on travis Feb 23, 2017

IgorMinar force-pushed the speed-up-ci branch 8 times, most recently from 6568f75 to aa024fa Compare February 24, 2017 18:25

IgorMinar force-pushed the speed-up-ci branch from aa024fa to ea35b5c Compare March 2, 2017 07:36

ci: clean up CI logging, folding, add build time logging, and improve…

241a5ab

… error handling

IgorMinar force-pushed the speed-up-ci branch from ea35b5c to 241a5ab Compare March 2, 2017 08:00

IgorMinar merged commit a24e652 into angular:master Mar 2, 2017

gkalpak mentioned this pull request Mar 6, 2017

ci(aio): correctly detect PRs and skip deploying to staging #14702

Closed

3 tasks

SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017

ci: clean up CI logging, folding, add build time logging, and improve…

6a7270d

… error handling (angular#14425)

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

ci: clean up CI logging, folding, add build time logging, and improve…

b6f21c1

… error handling (angular#14425)

juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

ci: clean up CI logging, folding, add build time logging, and improve…

ee30093

… error handling (angular#14425)

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: clean up logging and error handling on travis #14425

ci: clean up logging and error handling on travis #14425

IgorMinar commented Feb 11, 2017

IgorMinar Feb 21, 2017

alxhub Feb 22, 2017

IgorMinar Feb 23, 2017

alxhub Feb 22, 2017

IgorMinar Feb 23, 2017

alxhub Feb 22, 2017

alxhub Feb 22, 2017

alxhub Feb 22, 2017

IgorMinar Feb 23, 2017

alxhub Feb 22, 2017

IgorMinar Feb 22, 2017

gkalpak Feb 22, 2017

IgorMinar Feb 23, 2017

gkalpak Feb 22, 2017

gkalpak Feb 22, 2017

IgorMinar Feb 22, 2017

gkalpak Feb 22, 2017

IgorMinar Feb 22, 2017

usernamealreadyis commented Mar 3, 2017

angular-automatic-lock-bot bot commented Sep 10, 2019


		echo 'travis_fold:end:test.unit.localChrome'
		travisFoldStart "test.unit.localChrome"




		#[0Ktravis_fold:start:install

ci: clean up logging and error handling on travis #14425

ci: clean up logging and error handling on travis #14425

Conversation

IgorMinar commented Feb 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

usernamealreadyis commented Mar 3, 2017

angular-automatic-lock-bot bot commented Sep 10, 2019