feat: RendererV2 #14469

vicb · 2017-02-14T01:02:14Z

No description provided.

vicb · 2017-02-14T01:03:53Z

modules/@angular/core/src/debug/debug_node.ts

@@ -85,16 +85,26 @@ export class DebugElement extends DebugNode {
  insertChildrenAfter(child: DebugNode, newChildren: DebugNode[]) {


use insertBefore ?

Also add the breaking change in the commit msg

Not needed.

vicb · 2017-02-14T01:05:26Z

modules/@angular/core/src/render.ts

@@ -7,4 +7,4 @@
 */

 // Public API for render
-export {RenderComponentType, Renderer, RootRenderer} from './render/api';
+export {RENDERER_V2_TOKEN, RenderComponentType, Renderer, RendererV2, RootRenderer} from './render/api';


RENDERER_V2_IMPL

vicb · 2017-02-14T01:06:14Z

modules/@angular/core/src/view/element.ts

@@ -137,7 +137,12 @@ export function createElement(view: ViewData, renderHost: any, def: NodeDef): El
  if (view.parent || !rootSelectorOrNode) {
    const parentNode =
        def.parent != null ? asElementData(view, def.parent).renderElement : renderHost;
-    el = elDef.name ? renderer.createElement(elDef.name) : renderer.createComment('');
+    if (elDef.name) {


add todo: move in the def

I can fix it later on.

vicb · 2017-02-14T01:06:33Z

modules/@angular/core/src/view/element.ts

@@ -146,7 +151,8 @@ export function createElement(view: ViewData, renderHost: any, def: NodeDef): El
  }
  if (elDef.attrs) {
    for (let attrName in elDef.attrs) {
-      renderer.setAttribute(el, attrName, elDef.attrs[attrName]);
+      const nsAndName = splitNamespace(attrName);


add todo everywhere

vicb · 2017-02-14T01:07:44Z

modules/@angular/core/src/view/util.ts

@@ -180,6 +180,12 @@ export enum RenderNodeAction {

 export function visitRootRenderNodes(
    view: ViewData, action: RenderNodeAction, parentNode: any, nextSibling: any, target: any[]) {
+  // TODO: this should be done inside of the check for nodeDef.type === Nodetype.Element, ...


remove the todo

explain why, ie used when manually moving view nodes around

DzmitryShylovich · 2017-02-14T10:54:55Z

modules/@angular/platform-browser/src/dom/dom_renderer.ts

+
+  removeClass(el: any, name: string): void { el.classList.remove(name); }
+
+  setStyle(el: any, style: string, value: any): void { el.style[style] = value; }


can you also add priority arg for styles with important? https://github.com/angular/angular/pull/13281/files#diff-d8d7af6e45117a338e7c3bdc10701ccfR249

and support for vendor prefixed/css vars #12847

Thanks for the heads up, I'll add the params

tbosch · 2017-02-14T18:59:58Z

modules/@angular/core/src/render/api.ts

+ *
+ * @experimental
+ */
+export const RENDERER_V2_IMPL = new InjectionToken<RendererV2>('Renderer V2');


Rename to RENDERER_V2_DIRECT

DzmitryShylovich · 2017-02-14T22:17:16Z

modules/@angular/platform-browser/src/dom/dom_renderer.ts

+
+  removeClass(el: any, name: string): void { el.classList.remove(name); }
+
+  setStyle(el: any, style: string, value: any, hasVendorPrefix: boolean, hasImportant: boolean):


I think signature should be
setStyle(el: any, style: string, value: any, priority?: string)
and impl

setStyle(el: any, style: string, value: any, priority?: string) { if (style[0] === '-' || priority) { el.style.setProperty(style, value, priority); } else { el.style[style] = value; } }

priority?: string isntead of boolean because native setProperty wants a string.
hasVendorPrefix I think is not necessary because it's just a simple check style[0] === '-'

IgorMinar

LGMT - but I see that the api docs are missing. we should add these before the final release.

angular-automatic-lock-bot · 2019-09-10T21:20:43Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Feb 14, 2017

vicb commented Feb 14, 2017

View reviewed changes

vicb changed the title ~~feat: RendererV2~~ [WIP] feat: RendererV2 Feb 14, 2017

vicb force-pushed the 0208-renderv2 branch from 3d6282c to f2a7546 Compare February 14, 2017 03:02

DzmitryShylovich reviewed Feb 14, 2017

View reviewed changes

vicb force-pushed the 0208-renderv2 branch from f2a7546 to e84aea5 Compare February 14, 2017 18:47

vicb changed the title ~~[WIP] feat: RendererV2~~ feat: RendererV2 Feb 14, 2017

tbosch reviewed Feb 14, 2017

View reviewed changes

tbosch approved these changes Feb 14, 2017

View reviewed changes

tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 14, 2017

vicb force-pushed the 0208-renderv2 branch 3 times, most recently from 0e532ff to 1106d20 Compare February 14, 2017 21:31

vicb added area: core Issues related to the framework runtime and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 14, 2017

DzmitryShylovich reviewed Feb 14, 2017

View reviewed changes

vicb added the action: merge The PR is ready for merge by the caretaker label Feb 14, 2017

feat: RendererV2 integration

eb23cef

vicb force-pushed the 0208-renderv2 branch from 1106d20 to eb23cef Compare February 15, 2017 01:40

IgorMinar self-requested a review February 15, 2017 05:02

IgorMinar approved these changes Feb 15, 2017

View reviewed changes

IgorMinar merged commit bb9c7ae into angular:master Feb 15, 2017

vicb deleted the 0208-renderv2 branch February 16, 2017 18:56

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

feat: RendererV2 integration (angular#14469)

6fd4b01

juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

feat: RendererV2 integration (angular#14469)

0f5609a

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: RendererV2 #14469

feat: RendererV2 #14469

vicb commented Feb 14, 2017

vicb Feb 14, 2017

vicb Feb 14, 2017

tbosch Feb 14, 2017

vicb Feb 14, 2017

vicb Feb 14, 2017

tbosch Feb 14, 2017

vicb Feb 14, 2017

vicb Feb 14, 2017

vicb Feb 14, 2017

DzmitryShylovich Feb 14, 2017 •

edited

DzmitryShylovich Feb 14, 2017

vicb Feb 14, 2017

tbosch Feb 14, 2017

DzmitryShylovich Feb 14, 2017 •

edited

IgorMinar left a comment

angular-automatic-lock-bot bot commented Sep 10, 2019

		@@ -85,16 +85,26 @@ export class DebugElement extends DebugNode {
		insertChildrenAfter(child: DebugNode, newChildren: DebugNode[]) {


		removeClass(el: any, name: string): void { el.classList.remove(name); }

		setStyle(el: any, style: string, value: any): void { el.style[style] = value; }

feat: RendererV2 #14469

feat: RendererV2 #14469

Conversation

vicb commented Feb 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DzmitryShylovich Feb 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DzmitryShylovich Feb 14, 2017 • edited

Choose a reason for hiding this comment

IgorMinar left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 10, 2019

DzmitryShylovich Feb 14, 2017 •

edited

DzmitryShylovich Feb 14, 2017 •

edited