Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): implement style encapsulation for new view engine #14518

Merged
merged 1 commit into from
Feb 16, 2017
Merged

feat(compiler): implement style encapsulation for new view engine #14518

merged 1 commit into from
Feb 16, 2017

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Feb 15, 2017

No description provided.

@tbosch tbosch changed the title wip - fix renderer interface feat(compiler): implement style encapsulation for new view engine Feb 16, 2017
tbosch
tbosch commented Feb 16, 2017
View reviewed changes
modules/@angular/core/src/render/api.ts Outdated
styles: (string|any[])[];
data: {[kind: string]: any[]};
}
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 16, 2017
View reviewed changes
modules/@angular/core/src/render/api.ts Outdated
* in which case the view engine won't call it.
* This is used as a performance optimization for production mode.
*/
abstract destroyNode(node: any): void;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to destroyNode: (node: an) => void | null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 16, 2017
View reviewed changes
modules/@angular/core/src/view/index.ts Outdated
@@ -12,7 +12,7 @@ export {directiveDef, pipeDef, providerDef} from './provider';
export {pureArrayDef, pureObjectDef, purePipeDef} from './pure_expression';
export {queryDef} from './query';
export {createComponentFactory} from './refs';
export {initServicesIfNeeded} from './services';
export {getCurrentDebugContext, initServicesIfNeeded} from './services';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 16, 2017
View reviewed changes
modules/@angular/core/src/view/provider.ts Outdated
@@ -26,10 +28,20 @@ const InjectorRefTokenKey = tokenKey(Injector);

const NOT_CREATED = new Object();

let _renderCompCount = 0;

function nextRenderCompId() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong, id has to be passed to the directiveDef already!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 16, 2017
View reviewed changes
modules/@angular/core/src/view/services.ts Outdated
function normalizeDebugBindingValue(value: any): string {
try {
// Limit the size of the value as otherwise the DOM just gets polluted.
return value ? value.toString().slice(0, 10) : value;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe set to 20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 16, 2017
View reviewed changes
modules/@angular/platform-server/src/server.ts Outdated
@@ -42,8 +42,9 @@ export function _createConditionalRootRenderer(rootRenderer: any) {
return isDevMode() ? new DebugDomRootRenderer(rootRenderer) : rootRenderer;
}

export function _createDebugRendererV2(renderer: RendererV2): RendererV2 {
return isDevMode() ? new DebugDomRendererV2(renderer) : renderer;
export function _createDebugRendererV2(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Feb 16, 2017
@tbosch
feat(compiler): implement style encapsulation for new view engine
e8e39ba 
Included refactoring:
- splits the `RendererV2` into a `RendererFactoryV2` and a `RendererV2`
- makes the `DebugRendererV2` a private class in `@angular/core`
- remove `setBindingDebugInfo` from `RendererV2`, but rename `RendererV2.setText` to 
  `RendererV2.setValue` and allow it on comments and text nodes.

Part of angular#14013
@IgorMinar IgorMinar merged commit 0fa3895 into angular:master Feb 16, 2017
@tbosch tbosch deleted the view_renderer branch February 17, 2017 18:14
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@tbosch
feat(compiler): implement style encapsulation for new view engine (an…
8c981f5 
…gular#14518)

Included refactoring:
- splits the `RendererV2` into a `RendererFactoryV2` and a `RendererV2`
- makes the `DebugRendererV2` a private class in `@angular/core`
- remove `setBindingDebugInfo` from `RendererV2`, but rename `RendererV2.setText` to 
  `RendererV2.setValue` and allow it on comments and text nodes.

Part of angular#14013
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@tbosch @juleskremer
feat(compiler): implement style encapsulation for new view engine (an…
7ea0f5b 
…gular#14518)

Included refactoring:
- splits the `RendererV2` into a `RendererFactoryV2` and a `RendererV2`
- makes the `DebugRendererV2` a private class in `@angular/core`
- remove `setBindingDebugInfo` from `RendererV2`, but rename `RendererV2.setText` to 
  `RendererV2.setValue` and allow it on comments and text nodes.

Part of angular#14013
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tbosch @mhevery @vicb @IgorMinar @googlebot