Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix getLatestLabel #14535

Merged
merged 1 commit into from Feb 16, 2017
Merged

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Feb 16, 2017

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
getLatestLabel is broken when iteratively trying to deepen the clone.
Returns: Looking for latest tag at depth 100...\n4.0.0-beta.7

What is the new behavior?
getLatestLabel works correctly when iteratively trying to deepen the clone.
Returns: 4.0.0-beta.7

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer and removed cla: yes labels Feb 16, 2017
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please in the future explain briefly why this fix works. In this case it was not obvious and I had to look into it :-)

for the record, the output of this file is used to determine the version, so echoing anything else messes up with sed command that replaces version placeholders with the output from this script.

@IgorMinar IgorMinar merged commit 4a56b6e into angular:master Feb 16, 2017
@gkalpak gkalpak deleted the ci-fix-getLatestTag branch February 16, 2017 21:56
IgorMinar pushed a commit that referenced this pull request Feb 16, 2017
matsko pushed a commit to matsko/angular that referenced this pull request Feb 17, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants