Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular, SharePoint and IE11, Edge = Memory Leak #14555

Closed
andtii opened this issue Feb 17, 2017 · 12 comments
Closed

Angular, SharePoint and IE11, Edge = Memory Leak #14555

andtii opened this issue Feb 17, 2017 · 12 comments
Labels
area: core Issues related to the framework runtime memory leak Issue related to a memory leak needs reproduction This issue needs a reproduction in order for the team to investigate further type: bug/fix

Comments

@andtii
Copy link

andtii commented Feb 17, 2017

[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
Just by including Angular in a SharePoint environment a memory leaks starts to occur in IE11, Edge, for every page reload the memory increases and is never released until the browser is closed.

Expected behavior
No memory leak

Minimal reproduction of the problem with instructions

  1. Add a script editor webpart to a SharePoint page
  2. Include the angular javascripts
  3. Save and publish page
  4. Start reloading the page in Internet explorer 11
    You can see that the memory is increasing and it is not released between page loads

What is the motivation / use case for changing the behavior?
Memory Leak = Bad, We have 60+ customers running IE getting memory leak until browser hangs

Please tell us about your environment:
We have a SharePoint Online environment ready where you can get the login information so that you can test the behavior!

  • Angular version: 2.3.0

  • Browser: IE11, Edge

@DzmitryShylovich
Copy link
Contributor

did you enable prod mode?
Pls provide a repro

@andtii
Copy link
Author

andtii commented Feb 17, 2017

yes prod mode enabled and repro updated, we have a environment setup if you want to try it out i can hand out some login information

@DzmitryShylovich
Copy link
Contributor

Can you create a repository that we can clone that demonstrates this?

@mike-morr
Copy link

@andtii Can you provide the code they are inserting into the content editor web part?

@andtii
Copy link
Author

andtii commented Feb 21, 2017

@mike-morrison @DzmitryShylovich Here is the code in the script editor webpart

<script type="text/javascript" src="https://mod114707.sharepoint.com/Pages/angular2.bundle.libs.js"></script> <script type="text/javascript" src="https://mod114707.sharepoint.com/Pages/helloworld.js"></script>

And here is the code for helloworld component
https://gist.github.com/anonymous/7ab88a66d234357ae7ca28c9880a50c4

@andtii
Copy link
Author

andtii commented Feb 21, 2017

If someone wants to try it in SharePoint i can send you the login information.

@andtii
Copy link
Author

andtii commented Feb 23, 2017

@mizzle-mo @DzmitryShylovich Intrested helping out here? We can give out Login information to anyone intrested in getting this solved

@DzmitryShylovich
Copy link
Contributor

@andtii did you try angular 4?

@andtii
Copy link
Author

andtii commented Mar 8, 2017

@DzmitryShylovich Yes we tried angular 4 and still same problem

@tbosch tbosch added the area: core Issues related to the framework runtime label Apr 10, 2017
@tbosch
Copy link
Contributor

tbosch commented Apr 10, 2017

@andtii We really need a simpler way of reproducing this... Could you try to bisect the problem?

@chuckjaz chuckjaz added memory leak Issue related to a memory leak needs reproduction This issue needs a reproduction in order for the team to investigate further type: bug/fix labels Apr 13, 2017
@tbosch
Copy link
Contributor

tbosch commented Apr 25, 2017

Closing to keep our bug tracker under control. Please reopen once you have a good way of reproducing the problem. Thanks!

@tbosch tbosch closed this as completed Apr 25, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime memory leak Issue related to a memory leak needs reproduction This issue needs a reproduction in order for the team to investigate further type: bug/fix
Projects
None yet
Development

No branches or pull requests

5 participants