Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interfaces): Make ResponseOptionsArgs an interface #14607

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 21, 2017

supersedes #13708

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@vicb vicb added comp: http action: merge The PR is ready for merge by the caretaker labels Feb 21, 2017
@vicb vicb merged commit fbe4b76 into angular:master Feb 21, 2017
vicb added a commit that referenced this pull request Feb 21, 2017
vicb added a commit to vicb/angular that referenced this pull request Feb 21, 2017
vicb added a commit to vicb/angular that referenced this pull request Feb 24, 2017
vicb added a commit to vicb/angular that referenced this pull request Mar 15, 2017
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
@vicb vicb deleted the gh-13708 branch May 19, 2017 17:39
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: no
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants