Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): ErrorHandler should not rethrow an error by default #15077

Merged
merged 1 commit into from
Mar 13, 2017
Merged

fix(core): ErrorHandler should not rethrow an error by default #15077

merged 1 commit into from
Mar 13, 2017

Conversation

DzmitryShylovich
Copy link
Contributor

No description provided.

@chuckjaz chuckjaz merged commit 6559425 into angular:master Mar 13, 2017
@DzmitryShylovich DzmitryShylovich deleted the gh/13159 branch March 13, 2017 18:28
mhevery added a commit to mhevery/angular that referenced this pull request Mar 15, 2017
@mhevery
Revert "fix(core): ErrorHandler should not rethrow an error by default (
0adb86e 
angular#15077)"

This reverts commit 6559425.
chuckjaz pushed a commit that referenced this pull request Mar 15, 2017
@mhevery @chuckjaz
Revert "fix(core): ErrorHandler should not rethrow an error by default (
3131581 
#15077)"

This reverts commit 6559425.
mhevery added a commit to mhevery/angular that referenced this pull request Mar 16, 2017
@mhevery
fix(core): ErrorHandler should not rethrow an error by default (angul…
31117a6 
…ar#15077)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes angular#14949
Closes angular#15182
Closes angular#14316
mhevery added a commit to mhevery/angular that referenced this pull request Mar 16, 2017
@mhevery
fix(core): ErrorHandler should not rethrow an error by default (angul…
a47e82f 
…ar#15077)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes angular#14949
Closes angular#15182
Closes angular#14316
mhevery added a commit to mhevery/angular that referenced this pull request Mar 16, 2017
@mhevery
fix(core): ErrorHandler should not rethrow an error by default (angul…
4fde1bb 
…ar#15077)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes angular#14949
Closes angular#15182
Closes angular#14316
chuckjaz pushed a commit that referenced this pull request Mar 16, 2017
@mhevery @chuckjaz
fix(core): ErrorHandler should not rethrow an error by default (#15077)…
77fd91d 
… (#15208)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes #14949
Closes #15182
Closes #14316
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
@DzmitryShylovich @SamVerschueren
fix(core): ErrorHandler should not rethrow an error by default (angul…
30e650b 
…ar#15077)
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
@mhevery @SamVerschueren
Revert "fix(core): ErrorHandler should not rethrow an error by default (
34197c5 
angular#15077)"

This reverts commit 6559425.
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
@mhevery @SamVerschueren
fix(core): ErrorHandler should not rethrow an error by default (angul…
0ec9d92 
…ar#15077) (angular#15208)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes angular#14949
Closes angular#15182
Closes angular#14316
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@DzmitryShylovich
fix(core): ErrorHandler should not rethrow an error by default (angul…
a4f9dc8 
…ar#15077)
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@mhevery
Revert "fix(core): ErrorHandler should not rethrow an error by default (
3201c82 
angular#15077)"

This reverts commit 6559425.
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@mhevery
fix(core): ErrorHandler should not rethrow an error by default (angul…
5672ea4 
…ar#15077) (angular#15208)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes angular#14949
Closes angular#15182
Closes angular#14316
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@DzmitryShylovich @juleskremer
fix(core): ErrorHandler should not rethrow an error by default (angul…
cbcb435 
…ar#15077)
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@mhevery @juleskremer
Revert "fix(core): ErrorHandler should not rethrow an error by default (
9f071f5 
angular#15077)"

This reverts commit 6559425.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@mhevery @juleskremer
fix(core): ErrorHandler should not rethrow an error by default (angul…
16639bb 
…ar#15077) (angular#15208)

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes angular#14949
Closes angular#15182
Closes angular#14316
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DzmitryShylovich @chuckjaz @googlebot