Fix host animation for leave #15251

tbosch · 2017-03-17T18:39:03Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

googlebot · 2017-03-17T18:39:06Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

vicb · 2017-03-17T18:42:02Z

packages/core/src/codegen_private_exports.ts

@@ -10,4 +10,4 @@ export {CodegenComponentFactoryResolver as ɵCodegenComponentFactoryResolver} fr
 export {NgModuleInjector as ɵNgModuleInjector} from './linker/ng_module_factory';
 export {registerModuleFactory as ɵregisterModuleFactory} from './linker/ng_module_factory_loader';
 export {reflector as ɵreflector} from './reflection/reflection';
-export {ArgumentType as ɵArgumentType, BindingType as ɵBindingType, DepFlags as ɵDepFlags, EMPTY_ARRAY as ɵEMPTY_ARRAY, EMPTY_MAP as ɵEMPTY_MAP, NodeFlags as ɵNodeFlags, QueryBindingType as ɵQueryBindingType, QueryValueType as ɵQueryValueType, ViewDefinition as ɵViewDefinition, ViewFlags as ɵViewFlags, anchorDef as ɵand, createComponentFactory as ɵccf, createRendererType2 as ɵcrt, directiveDef as ɵdid, elementDef as ɵeld, elementEventFullName as ɵelementEventFullName, getComponentViewDefinitionFactory as ɵgetComponentViewDefinitionFactory, inlineInterpolate as ɵinlineInterpolate, interpolate as ɵinterpolate, ngContentDef as ɵncd, nodeValue as ɵnov, pipeDef as ɵpid, providerDef as ɵprd, pureArrayDef as ɵpad, pureObjectDef as ɵpod, purePipeDef as ɵppd, queryDef as ɵqud, textDef as ɵted, unwrapValue as ɵunv, viewDef as ɵvid} from './view/index';
+export {ArgumentType as ɵArgumentType, BindingFlags as ɵBindingType, DepFlags as ɵDepFlags, EMPTY_ARRAY as ɵEMPTY_ARRAY, EMPTY_MAP as ɵEMPTY_MAP, NodeFlags as ɵNodeFlags, QueryBindingType as ɵQueryBindingType, QueryValueType as ɵQueryValueType, ViewDefinition as ɵViewDefinition, ViewFlags as ɵViewFlags, anchorDef as ɵand, createComponentFactory as ɵccf, createRendererType2 as ɵcrt, directiveDef as ɵdid, elementDef as ɵeld, elementEventFullName as ɵelementEventFullName, getComponentViewDefinitionFactory as ɵgetComponentViewDefinitionFactory, inlineInterpolate as ɵinlineInterpolate, interpolate as ɵinterpolate, ngContentDef as ɵncd, nodeValue as ɵnov, pipeDef as ɵpid, providerDef as ɵprd, pureArrayDef as ɵpad, pureObjectDef as ɵpod, purePipeDef as ɵppd, queryDef as ɵqud, textDef as ɵted, unwrapValue as ɵunv, viewDef as ɵvid} from './view/index';


ɵBindingFlags

vicb · 2017-03-17T18:48:44Z

packages/core/test/animation/animation_integration_spec.ts

+               animations: [trigger(
+                   'myAnimation',
+                   [transition(
+                       'a => b',


void =>smthg

Changed description of the test.

vicb · 2017-03-17T18:49:18Z

packages/core/test/animation/animation_integration_spec.ts

+               @HostBinding('@myAnimation')
+               get binding() { return this.exp ? 'b' : 'a'; }
+
+               exp: any = false;


nit: boolean

vicb · 2017-03-17T18:50:20Z

packages/core/test/animation/animation_integration_spec.ts

+             expect(data.element).toEqual(fixture.elementRef.nativeElement);
+             expect(data.keyframes).toEqual([{offset: 0, opacity: '0'}, {offset: 1, opacity: '1'}]);
+
+             flushMicrotasks();


no child, remove

matsko · 2017-03-17T19:43:41Z

I'm just commenting here to confirm that Tobias is including my testing commit so that we can guarantee that the animation tests now work.

Fixes angular#14813 Fixes angular#15193

…indings

…15251)

…5251) Fixes #14813 Fixes #15193

…ngular#15251)

…gular#15251) Fixes angular#14813 Fixes angular#15193

…indings (angular#15251) PR Close angular#15251

…ngular#15251)

…gular#15251) Fixes angular#14813 Fixes angular#15193

…indings (angular#15251) PR Close angular#15251

angular-automatic-lock-bot · 2019-09-11T11:21:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label Mar 17, 2017

vicb reviewed Mar 17, 2017

View reviewed changes

vicb approved these changes Mar 17, 2017

View reviewed changes

tbosch mentioned this pull request Mar 17, 2017

test(animations): test various combinations of animations with host bindings #15225

Closed

tbosch force-pushed the fix_anim branch 2 times, most recently from 1988c7c to 357c1f6 Compare March 17, 2017 20:39

refactor(core): view engine - change BindingType to BindingFlags

0140078

tbosch force-pushed the fix_anim branch from 357c1f6 to e2fabd3 Compare March 17, 2017 20:51

tbosch added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2017

mhevery added the pr_action: queued label Mar 17, 2017

tbosch removed action: merge The PR is ready for merge by the caretaker pr_action: queued labels Mar 17, 2017

tbosch and others added 2 commits March 17, 2017 16:52

fix(core): trigger host animations for elements that are removed.

b6b9afd

Fixes angular#14813 Fixes angular#15193

test(animations): test various combinations of animations with host b…

4699e79

…indings

tbosch force-pushed the fix_anim branch from e2fabd3 to 4699e79 Compare March 17, 2017 23:52

tbosch added the action: merge The PR is ready for merge by the caretaker label Mar 18, 2017

mhevery pushed a commit that referenced this pull request Mar 19, 2017

refactor(core): view engine - change BindingType to BindingFlags (#…

28ce68a

…15251)

mhevery pushed a commit that referenced this pull request Mar 19, 2017

fix(core): trigger host animations for elements that are removed. (#1…

0d3e314

…5251) Fixes #14813 Fixes #15193

mhevery closed this in aeb9964 Mar 19, 2017

tbosch deleted the fix_anim branch April 28, 2017 23:38

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

refactor(core): view engine - change BindingType to BindingFlags (a…

c38eb8f

…ngular#15251)

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

fix(core): trigger host animations for elements that are removed. (an…

22b7e0d

…gular#15251) Fixes angular#14813 Fixes angular#15193

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

test(animations): test various combinations of animations with host b…

6c35230

…indings (angular#15251) PR Close angular#15251

juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

refactor(core): view engine - change BindingType to BindingFlags (a…

75db03e

…ngular#15251)

juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

fix(core): trigger host animations for elements that are removed. (an…

fdcf4c4

…gular#15251) Fixes angular#14813 Fixes angular#15193

juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

test(animations): test various combinations of animations with host b…

ea61530

…indings (angular#15251) PR Close angular#15251

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix host animation for leave #15251

Fix host animation for leave #15251

tbosch commented Mar 17, 2017

googlebot commented Mar 17, 2017

vicb Mar 17, 2017

tbosch Mar 17, 2017

vicb Mar 17, 2017

tbosch Mar 17, 2017

vicb Mar 17, 2017

tbosch Mar 17, 2017

vicb Mar 17, 2017

tbosch Mar 17, 2017

matsko commented Mar 17, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

Fix host animation for leave #15251

Fix host animation for leave #15251

Conversation

tbosch commented Mar 17, 2017

googlebot commented Mar 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matsko commented Mar 17, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019