Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use object spread operator rather than merge #15426

Merged
merged 1 commit into from Mar 24, 2017

Conversation

DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Mar 23, 2017

Object spread operator was introduced in Typescript 2.1 so we no longer need to use neither Object.assign not custom merge function.

@DzmitryShylovich DzmitryShylovich changed the title refactor: wip refactor: use object spread operator rather than merge Mar 23, 2017
@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Mar 23, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicb vicb merged commit c17b912 into angular:master Mar 24, 2017
@DzmitryShylovich DzmitryShylovich deleted the gh/object-spread branch March 24, 2017 21:46
sjtrimble pushed a commit to sjtrimble/angular that referenced this pull request Mar 25, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants