Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aio): enable activating available ServiceWorker updates #15561

Merged
merged 1 commit into from Mar 30, 2017
Merged

feat(aio): enable activating available ServiceWorker updates #15561

merged 1 commit into from Mar 30, 2017

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 28, 2017

No description provided.

@gkalpak gkalpak force-pushed the feat-aio-install-sw-updates branch from d698200 to 03bd0b1 Compare March 28, 2017 18:27
@gkalpak gkalpak added this to WIP in docs-infra Mar 28, 2017
@gkalpak gkalpak force-pushed the feat-aio-install-sw-updates branch 2 times, most recently from 544acac to 8458431 Compare March 28, 2017 19:58
@gkalpak gkalpak added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 28, 2017
@mary-poppins
Copy link

The angular.io preview for 8458431 is available here.

@gkalpak gkalpak force-pushed the feat-aio-install-sw-updates branch from 8458431 to 280900d Compare March 29, 2017 15:51
@mary-poppins
Copy link

The angular.io preview for 280900d is available here.

@gkalpak gkalpak changed the title WIP - feat(aio): enable activating available ServiceWorker updates feat(aio): enable activating available ServiceWorker updates Mar 29, 2017
@mary-poppins
Copy link

The angular.io preview for 96860c0 is available here.

@gkalpak
Copy link
Member Author

gkalpak commented Mar 29, 2017

This is now ready for review. Open for debate (probably for future PRs):

  1. At what intervals to poll for updates (currently every 6 hours).
  2. Whether to automatically reload the page after activating an update (currently we prompt the user to reload).
  3. How to notify/prompt the user (currently using a vanilla MdSnackBar).
  4. Notification messages and actions. Currently:

    • Update available:
      ServiceWorker update available. Activate

    • Activation failed:
      Update activation failed :( Dismiss (autohides after 5secs)

    • Activation succeeded:
      Update activated successfully! Reload the page to see the latest content. (never hides)

@gkalpak gkalpak moved this from WIP to REVIEW in docs-infra Mar 29, 2017
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 29, 2017
@gkalpak gkalpak force-pushed the feat-aio-install-sw-updates branch from 96860c0 to 120440d Compare March 29, 2017 19:30
@gkalpak
Copy link
Member Author

gkalpak commented Mar 29, 2017

*Squashed*

@mary-poppins
Copy link

The angular.io preview for 120440d is available here.

@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Mar 29, 2017
@vicb
Copy link
Contributor

vicb commented Mar 29, 2017

Please re-add the merge label when conflicts are resolved

@vicb vicb removed the action: merge The PR is ready for merge by the caretaker label Mar 29, 2017
@gkalpak gkalpak force-pushed the feat-aio-install-sw-updates branch from 120440d to 7643ac3 Compare March 30, 2017 05:51
@mary-poppins
Copy link

The angular.io preview for 7643ac3 is available here.

@gkalpak gkalpak force-pushed the feat-aio-install-sw-updates branch from 7643ac3 to d9a25d1 Compare March 30, 2017 06:08
@mary-poppins
Copy link

The angular.io preview for d9a25d1 is available here.

@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2017
@IgorMinar IgorMinar merged commit 3ccbe28 into angular:master Mar 30, 2017
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Mar 30, 2017
@gkalpak gkalpak deleted the feat-aio-install-sw-updates branch March 30, 2017 10:39
@gkalpak gkalpak mentioned this pull request Apr 11, 2017
Closed
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@gkalpak
feat(aio): enable activating available ServiceWorker updates (angular…
8acbc13 
…#15561)
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@gkalpak @juleskremer
feat(aio): enable activating available ServiceWorker updates (angular…
d00a111 
…#15561)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gkalpak @mary-poppins @vicb @IgorMinar @googlebot