Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): EventEmitter docs for isAsync defaults #15780

Merged
merged 1 commit into from May 8, 2017

Conversation

dherges
Copy link
Contributor

@dherges dherges commented Apr 5, 2017

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Solves #15758

What is the new behavior?

Solves #15758

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Other information:

@dherges
Copy link
Contributor Author

dherges commented May 3, 2017

@IgorMinar @mhevery @tbosch @vicb Getting feedback (whether positive or negative) would be nice!

@tbosch
Copy link
Contributor

tbosch commented May 5, 2017

Looks good, please update the commit message to docs(core): ...

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label May 5, 2017
@dherges dherges force-pushed the refactor/eventemitter-docs branch from 95eb8fb to 3cd91c6 Compare May 6, 2017 08:03
@dherges dherges changed the title refactor(core): EventEmitter docs for isAsync defaults docs(core): EventEmitter docs for isAsync defaults May 6, 2017
@dherges dherges force-pushed the refactor/eventemitter-docs branch from 3cd91c6 to 5ef06f1 Compare May 6, 2017 08:28
@dherges
Copy link
Contributor Author

dherges commented May 6, 2017

@tbosch Done. Thanks for your reply!

@mhevery mhevery merged commit c5ce040 into angular:master May 8, 2017
@dherges dherges deleted the refactor/eventemitter-docs branch May 8, 2017 20:01
jasonaden pushed a commit to jasonaden/angular that referenced this pull request May 10, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants