Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler): cleanup #15960

Merged
merged 1 commit into from Apr 13, 2017
Merged

refactor(compiler): cleanup #15960

merged 1 commit into from Apr 13, 2017

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 13, 2017

No description provided.

@vicb vicb added area: core Issues related to the framework runtime action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2017
@vicb vicb requested a review from chuckjaz April 13, 2017 18:00
chuckjaz
chuckjaz approved these changes Apr 13, 2017
View reviewed changes
packages/compiler/src/template_parser/template_parser.ts Outdated
templateUrl: string): TemplateParseResult {
htmlAstWithErrors: ParseTreeResult, component: CompileDirectiveMetadata,
directives: CompileDirectiveSummary[], pipes: CompilePipeSummary[],
schemas: SchemaMetadata[], ): TemplateParseResult {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comma?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2017
@tbosch tbosch merged commit fdb3f26 into angular:master Apr 13, 2017
mhevery pushed a commit that referenced this pull request Apr 21, 2017
@vicb @mhevery
refactor(compiler): cleanup (#15960)
aced68a
mhevery pushed a commit that referenced this pull request Apr 21, 2017
@vicb @mhevery
refactor(compiler): cleanup (#15960)
6604a4d
@vicb vicb deleted the 0413-ref branch May 19, 2017 17:27
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@vicb
refactor(compiler): cleanup (angular#15960)
c3913f9
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@vicb @juleskremer
refactor(compiler): cleanup (angular#15960)
4fb8b16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckjaz chuckjaz chuckjaz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicb @chuckjaz @tbosch @googlebot