docs(aio): apply guidelines and update TOCs in ts-to-js #16054

kapunahelewong · 2017-04-17T17:32:52Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: Copy edits to apply guidelines, make TOCs reflect doc shape, and clean up spaces added by migration tool.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

mary-poppins · 2017-04-17T17:45:45Z

The angular.io preview for b31dab8 is available here.

Foxandxss · 2017-04-17T18:55:43Z

aio/content/guide/ts-to-js.md

 ## AOT Compilation in _TypeScript_ only

-Angular offers two modes of template compilation, JIT (_Just-in-Time_) and
-[AOT (_Ahead-of-Time_)](guide/aot-compiler).
+Angular offers two modes of template compilation, JIT (_just-in-time_) and


why lowercase? And wasn't it JiT and AoT?

@Foxandxss It was recently changed in the wordlist.

Foxandxss · 2017-04-17T18:57:15Z

aio/content/guide/ts-to-js.md

 <div class="l-sub-section">
-
-
-
 In the example above, there is no provider for the `'titlePrefix'` token.


can we indent this? Not sure if it is a good idea but I think so

@Foxandxss Sure - I just tried it and it worked. Last week it broke it to indent it. I like it indented better too.

EDIT: Another didn't work because there was a <script> tag in the copy that throws it. Have to keep the spacing on that one, but any other <div> should take indentation fine.

mary-poppins · 2017-04-17T19:30:40Z

The angular.io preview for 9e89c48 is available here.

mary-poppins · 2017-04-17T20:27:27Z

The angular.io preview for 6a6c121 is available here.

mary-poppins · 2017-04-19T16:05:05Z

The angular.io preview for 1d1b06a is available here.

mary-poppins · 2017-04-19T16:05:21Z

The angular.io preview for bd2c9fb is available here.

petebacondarwin · 2017-04-20T07:07:26Z

aio/content/guide/ts-to-js.md

 </code-tabs>

-
-
 <div class="l-sub-section">


you need a blank line here for the next lines to be recognized as markdown rather than plain HTML

petebacondarwin · 2017-04-20T07:07:59Z

aio/content/guide/ts-to-js.md

+  In the example above, there is no provider for the `'titlePrefix'` token.
+  Without `@Optional()`, Angular would raise an error.
+  With `@Optional()`, Angular sets the constructor parameter to `null`
+  and the component displays the title without a prefix.


and a blank line here

petebacondarwin · 2017-04-20T07:08:43Z

aio/content/guide/ts-to-js.md

 <div class="l-sub-section">
+  _View_ children are associated with element tags that appear _within_ the component's template.


blank line before this line - and before the </div> below.

petebacondarwin · 2017-04-20T07:09:07Z

aio/content/guide/ts-to-js.md

-instead of the `@ViewChild` and `@ContentChild` property decorators.
-
-
+  In _TypeScript_ and _ES6-with-decorators_ you can also use the  `queries` metadata


you get the idea :-)

Yes, thank you for looking out! :)

petebacondarwin

if you have a block of HTML that should contain markdown then you need to separate the markdown from the HTML by blank lines.

mary-poppins · 2017-04-20T14:41:08Z

The angular.io preview for c05efcf is available here.

mary-poppins · 2017-04-21T16:59:03Z

The angular.io preview for a145e73 is available here.

googlebot · 2017-04-28T02:18:59Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

wardbell · 2017-04-28T02:19:12Z

@kapunahelewong fixed the HTML problems noted by @petebacondarwin.
I fixed merge conflicts related to the relocation of the sample files.
Deleted manual TOC in favor of auto-generated TOC (which is our strong preference everywhere).
We both have signed the CLA.

This PR LGTM

wardbell

LGTM. This is a pure docs change the the Travis error is an unrelated flake. Merge away.

mary-poppins · 2017-04-28T02:35:03Z

The angular.io preview for 1749f04 is available here.

mhevery · 2017-04-28T04:42:24Z

fix circle/ rebase

googlebot · 2017-04-28T09:42:41Z

CLAs look good, thanks!

mary-poppins · 2017-04-28T09:58:23Z

The angular.io preview for 8244bcf is available here.

mary-poppins · 2017-04-28T10:00:59Z

The angular.io preview for 0415112 is available here.

…#16054)

angular-automatic-lock-bot · 2019-09-11T11:21:59Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 17, 2017

kapunahelewong changed the title ~~docs(ts-to-js): apply guidelines and update TOCs~~ [WIP] docs(ts-to-js): apply guidelines and update TOCs Apr 17, 2017

Foxandxss reviewed Apr 17, 2017

View reviewed changes

wardbell added the comp: aio label Apr 17, 2017

kapunahelewong force-pushed the wong-ts-to-js branch from b31dab8 to 9e89c48 Compare April 17, 2017 19:17

kapunahelewong force-pushed the wong-ts-to-js branch from 9e89c48 to 6a6c121 Compare April 17, 2017 20:13

petebacondarwin added this to Content Only in docs-infra Apr 19, 2017

kapunahelewong force-pushed the wong-ts-to-js branch 2 times, most recently from bd2c9fb to 1d1b06a Compare April 19, 2017 15:48

kapunahelewong changed the title ~~[WIP] docs(ts-to-js): apply guidelines and update TOCs~~ [WIP] docs(aio): apply guidelines and update TOCs on ts-to-js Apr 19, 2017

kapunahelewong changed the title ~~[WIP] docs(aio): apply guidelines and update TOCs on ts-to-js~~ [WIP] docs(aio): apply guidelines and update TOCs in ts-to-js Apr 19, 2017

kapunahelewong changed the title ~~[WIP] docs(aio): apply guidelines and update TOCs in ts-to-js~~ docs(aio): apply guidelines and update TOCs in ts-to-js Apr 19, 2017

petebacondarwin reviewed Apr 20, 2017

View reviewed changes

petebacondarwin requested changes Apr 20, 2017

View reviewed changes

petebacondarwin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 20, 2017

kapunahelewong force-pushed the wong-ts-to-js branch from 1d1b06a to c05efcf Compare April 20, 2017 14:21

kapunahelewong force-pushed the wong-ts-to-js branch from c05efcf to a145e73 Compare April 21, 2017 16:42

wardbell removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 28, 2017

googlebot added cla: no and removed cla: yes labels Apr 28, 2017

wardbell self-requested a review April 28, 2017 02:20

wardbell assigned kapunahelewong Apr 28, 2017

wardbell added comp: docs action: merge The PR is ready for merge by the caretaker labels Apr 28, 2017

wardbell approved these changes Apr 28, 2017

View reviewed changes

wardbell force-pushed the wong-ts-to-js branch from 1749f04 to 8244bcf Compare April 28, 2017 09:42

googlebot added cla: yes and removed cla: no labels Apr 28, 2017

docs(aio): apply guidelines to ts-to-js - adapt for aio site

0415112

wardbell force-pushed the wong-ts-to-js branch from 8244bcf to 0415112 Compare April 28, 2017 09:44

mhevery merged commit b70b960 into angular:master Apr 28, 2017

wardbell moved this from Content Only to MERGE in docs-infra May 1, 2017

wardbell removed this from MERGE in docs-infra May 1, 2017

kapunahelewong deleted the wong-ts-to-js branch May 1, 2017 15:41

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

docs(aio): apply guidelines to ts-to-js - adapt for aio site (angular…

9302f92

…#16054)

juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

docs(aio): apply guidelines to ts-to-js - adapt for aio site (angular…

782683d

…#16054)

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(aio): apply guidelines and update TOCs in ts-to-js #16054

docs(aio): apply guidelines and update TOCs in ts-to-js #16054

kapunahelewong commented Apr 17, 2017 •

edited

mary-poppins commented Apr 17, 2017

Foxandxss Apr 17, 2017

kapunahelewong Apr 17, 2017

Foxandxss Apr 17, 2017

kapunahelewong Apr 17, 2017 •

edited

mary-poppins commented Apr 17, 2017

mary-poppins commented Apr 17, 2017

mary-poppins commented Apr 19, 2017

mary-poppins commented Apr 19, 2017

petebacondarwin Apr 20, 2017

kapunahelewong Apr 20, 2017

petebacondarwin Apr 20, 2017

kapunahelewong Apr 20, 2017

petebacondarwin Apr 20, 2017

kapunahelewong Apr 20, 2017

petebacondarwin Apr 20, 2017

kapunahelewong Apr 20, 2017

petebacondarwin left a comment

mary-poppins commented Apr 20, 2017

mary-poppins commented Apr 21, 2017

googlebot commented Apr 28, 2017

wardbell commented Apr 28, 2017 •

edited

wardbell left a comment •

edited

mary-poppins commented Apr 28, 2017

mhevery commented Apr 28, 2017

googlebot commented Apr 28, 2017

mary-poppins commented Apr 28, 2017

mary-poppins commented Apr 28, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

		<div class="l-sub-section">



		In the example above, there is no provider for the `'titlePrefix'` token.

		<div class="l-sub-section">
		_View_ children are associated with element tags that appear _within_ the component's template.

		instead of the `@ViewChild` and `@ContentChild` property decorators.


		In _TypeScript_ and _ES6-with-decorators_ you can also use the `queries` metadata

docs(aio): apply guidelines and update TOCs in ts-to-js #16054

docs(aio): apply guidelines and update TOCs in ts-to-js #16054

Conversation

kapunahelewong commented Apr 17, 2017 • edited

mary-poppins commented Apr 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kapunahelewong Apr 17, 2017 • edited

Choose a reason for hiding this comment

mary-poppins commented Apr 17, 2017

mary-poppins commented Apr 17, 2017

mary-poppins commented Apr 19, 2017

mary-poppins commented Apr 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

mary-poppins commented Apr 20, 2017

mary-poppins commented Apr 21, 2017

googlebot commented Apr 28, 2017

wardbell commented Apr 28, 2017 • edited

wardbell left a comment • edited

Choose a reason for hiding this comment

mary-poppins commented Apr 28, 2017

mhevery commented Apr 28, 2017

googlebot commented Apr 28, 2017

mary-poppins commented Apr 28, 2017

mary-poppins commented Apr 28, 2017

angular-automatic-lock-bot bot commented Sep 11, 2019

kapunahelewong commented Apr 17, 2017 •

edited

kapunahelewong Apr 17, 2017 •

edited

wardbell commented Apr 28, 2017 •

edited

wardbell left a comment •

edited