Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): change hardcoded links to the old site #16196

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Foxandxss
Copy link
Member

While this change is pretty much straightforward, I require @wardbell since I made a prose change.

@mary-poppins
Copy link

The angular.io preview for b0c7775 is available here.

@petebacondarwin petebacondarwin added this to Content Only in docs-infra Apr 20, 2017
Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One word change ... "run" replaces "ran" ... and its good. I trust you'll make that change and so I "approve".

The _Tour of Heroes_ source code is in the `public/docs/_examples/toh-6/ts` folder.
The following instructions presuppose that you have downloaded the
<a href="/content/zips/toh-pt6/toh-pt6.zip" target="_blank">Tour of Heroes' zip</a>
and ran `npm install` on it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"run"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@@ -364,7 +364,7 @@ As much fun as this is ...
Use the <live-example title="QuickStart Seed in Plunker">live coding</live-example> environment as a _playground_,
a place to try the documentation samples and experiment on your own.
It's the perfect place to reproduce a bug when you want to
<a href="https://github.com/angular/angular.io/issues/new" target="_blank" title="File a documentation issue">file a documentation issue</a> or
<a href="https://github.com/angular/angular/issues/new" target="_blank" title="File a documentation issue">file a documentation issue</a> or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igor wants us to remove target="_blank"

@mary-poppins
Copy link

The angular.io preview for 4c77a6b is available here.

@Foxandxss
Copy link
Member Author

This one is good to go

@Foxandxss Foxandxss added the action: merge The PR is ready for merge by the caretaker label Apr 21, 2017
@mhevery mhevery merged commit 062fc4a into angular:master Apr 21, 2017
@petebacondarwin petebacondarwin removed this from Content Only in docs-infra Apr 24, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants