New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aio): change hardcoded links to the old site #16196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One word change ... "run" replaces "ran" ... and its good. I trust you'll make that change and so I "approve".
aio/content/guide/aot-compiler.md
Outdated
The _Tour of Heroes_ source code is in the `public/docs/_examples/toh-6/ts` folder. | ||
The following instructions presuppose that you have downloaded the | ||
<a href="/content/zips/toh-pt6/toh-pt6.zip" target="_blank">Tour of Heroes' zip</a> | ||
and ran `npm install` on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"run"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
aio/content/guide/setup.md
Outdated
@@ -364,7 +364,7 @@ As much fun as this is ... | |||
Use the <live-example title="QuickStart Seed in Plunker">live coding</live-example> environment as a _playground_, | |||
a place to try the documentation samples and experiment on your own. | |||
It's the perfect place to reproduce a bug when you want to | |||
<a href="https://github.com/angular/angular.io/issues/new" target="_blank" title="File a documentation issue">file a documentation issue</a> or | |||
<a href="https://github.com/angular/angular/issues/new" target="_blank" title="File a documentation issue">file a documentation issue</a> or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Igor wants us to remove target="_blank"
b0c7775
to
06334a4
Compare
06334a4
to
4c77a6b
Compare
This one is good to go |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
While this change is pretty much straightforward, I require @wardbell since I made a prose change.