Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): correct abbreviation #16295

Merged
merged 1 commit into from Apr 28, 2017
Merged

docs(aio): correct abbreviation #16295

merged 1 commit into from Apr 28, 2017

Conversation

swseverance
Copy link
Contributor

change abbreviation from 'ES' to 'ES2015'. the 'ES2015' abbreviation is used elsewhere in the tutorial.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: Fix to documentation

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

change abbreviation from 'ES' to 'ES2015'. the 'ES2015' abbreviation is used elsewhere in the tutorial.
@Toxicable
Copy link

Toxicable commented Apr 25, 2017

You need to re-generate the Docs

@gkalpak
Copy link
Member

gkalpak commented Apr 25, 2017

@Toxicable, not sure what you mean 😕

@gkalpak gkalpak added this to Content Only in docs-infra Apr 25, 2017
@Toxicable
Copy link

@gkalpak Neither am I. The error in Travis said that the docs that the docs should be regnerated, so I was just reiterating that incase it was missed to try get this through since it's an easy one

@gkalpak
Copy link
Member

gkalpak commented Apr 25, 2017

The Travis failure was a flake 😃 I restarted it and it's all good now.
This looks good to go (cc @wardbell).

@IgorMinar
Copy link
Contributor

IgorMinar commented Apr 25, 2017

Unfortunately I don't think that this change is right. The import keyword is part of the ES (ECMAScript) spec, it just happened to be introduced in ES2015, but that's not really interesting to the reader. We should stay away from listing the versions of any kind anywhere (ES spec or Angular) unless we actually want to point out when that particular feature was introduced.

cc: @wardbell

@swseverance
Copy link
Contributor Author

If that's the case you may consider replacing the references to 'ES2015' found in toh-pt1.md & toh-pt4.md

@wardbell
Copy link
Contributor

wardbell commented Apr 28, 2017

@IgorMinar - @swseverance has a point. We have called out ES2015 all over the place.

Many of us who routinely write about such things have called out features introduced in ES2015 so people who know only old JavaScript become aware of the change. Module support is still shocking to most developers as I write this.

Maybe you're right that it's time to stop doing that and we can just say ES from now on (or why not just say "JavaScript"?). We can start a sweep to replace all "ES2015" as a separate effort in a separate PR.

Meanwhile, I'll approve this in my capacity as "docs editor" and we can discuss a change of policy offline.

@wardbell wardbell added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2017
@mhevery mhevery merged commit fbde2a8 into angular:master Apr 28, 2017
@petebacondarwin petebacondarwin removed this from Content Only in docs-infra Apr 28, 2017
@swseverance swseverance deleted the patch-1 branch April 28, 2017 09:39
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
change abbreviation from 'ES' to 'ES2015'. the 'ES2015' abbreviation is used elsewhere in the tutorial.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
change abbreviation from 'ES' to 'ES2015'. the 'ES2015' abbreviation is used elsewhere in the tutorial.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants