Some fixes for @angular/core #16394
Closed
Some fixes for @angular/core #16394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Apr 27, 2017
packages/core/src/view/provider.ts
Outdated
| if (tokenKey === ChangeDetectorRefTokenKey) { | ||
| // directives on the same element as a component should be able to control the change detector | ||
| // of that component as well. | ||
| allowPrivateServices = elDef && !!elDef.element !.componentView; |
vicb
reviewed
Apr 27, 2017
| comp.counter = 1; | ||
| cf.detectChanges(); | ||
| expect(compEl.nativeElement).toHaveText('0'); | ||
| dir.changeDetectorRef.markForCheck(); |
There was a problem hiding this comment.
what is dir.changeDetectorRef in this case ?
There was a problem hiding this comment.
It's the changeDetectorRef that the directive received. The test verifies that it cannot change mark the component on the parent element as being dirty.
vicb
reviewed
Apr 27, 2017
| const compRef = | ||
| modRef.componentFactoryResolver.resolveComponentFactory(App).create(Injector.NULL); | ||
|
|
||
| expect(getDOM().getAttribute(compRef.location.nativeElement, 'ng-version')).toBeFalsy(); |
There was a problem hiding this comment.
you want hasAttribute here, no ?
vicb
approved these changes
Apr 28, 2017
…Ref`. When a directive lives on the same element as a component (e.g. `<my-comp myDir>`), the directive was not able to get hold of the `ChangeDetectorRef` of the component on that element. However, as directives are supposed to decorate components, this is incorrect. This commit enables this use case. Closes angular#12816
Angular uses the `ng-version` attribute to indicate which elements were used to bootstrap an application. However, after 4.0 we also added this attribute for all dynamically created components. Fixes angular#15880
mhevery
pushed a commit
that referenced
this pull request
Apr 28, 2017
…Ref`. (#16394) When a directive lives on the same element as a component (e.g. `<my-comp myDir>`), the directive was not able to get hold of the `ChangeDetectorRef` of the component on that element. However, as directives are supposed to decorate components, this is incorrect. This commit enables this use case. Closes #12816
mhevery
pushed a commit
that referenced
this pull request
Apr 28, 2017
matsko
pushed a commit
that referenced
this pull request
May 4, 2017
…Ref`. (#16394) When a directive lives on the same element as a component (e.g. `<my-comp myDir>`), the directive was not able to get hold of the `ChangeDetectorRef` of the component on that element. However, as directives are supposed to decorate components, this is incorrect. This commit enables this use case. Closes #12816
matsko
pushed a commit
that referenced
this pull request
May 4, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…Ref`. (angular#16394) When a directive lives on the same element as a component (e.g. `<my-comp myDir>`), the directive was not able to get hold of the `ChangeDetectorRef` of the component on that element. However, as directives are supposed to decorate components, this is incorrect. This commit enables this use case. Closes angular#12816
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ngular#16394) Angular uses the `ng-version` attribute to indicate which elements were used to bootstrap an application. However, after 4.0 we also added this attribute for all dynamically created components. Fixes angular#15880 PR Close angular#16394
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…Ref`. (angular#16394) When a directive lives on the same element as a component (e.g. `<my-comp myDir>`), the directive was not able to get hold of the `ChangeDetectorRef` of the component on that element. However, as directives are supposed to decorate components, this is incorrect. This commit enables this use case. Closes angular#12816
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ngular#16394) Angular uses the `ng-version` attribute to indicate which elements were used to bootstrap an application. However, after 4.0 we also added this attribute for all dynamically created components. Fixes angular#15880 PR Close angular#16394
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.