New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aio): add marketing class to AppComponent <aio-shell> on mkt page #16395
feat(aio): add marketing class to AppComponent <aio-shell> on mkt page #16395
Conversation
These could be separate PRs, indeed, but if in a single PR they really should be separate commits no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to hidden stuff LGTM
The changes to adding the marketing
css class would be simpler via a HostBinding
I think:
@HostBinding('class.marketing') get isMarketing() { return !isSideNavDoc; }
682d093
to
5788038
Compare
Lovely! Please squash |
I don't know if actually simpler (personally don't think so) but certainly more Angular idiomatic. Added in the 2nd commit. Btw, I used an I don't disagree with your point about separate commits ... having raised it myself ... but I've seen worse from absolutely everyone. Is it a blocker? I hope not. |
5788038
to
26b07e6
Compare
Also navigation.json Doc page should be hidden in sidebar, shown in top
26b07e6
to
dcf2add
Compare
💔 |
angular#16395) Also navigation.json Doc page should be hidden in sidebar, shown in top
angular#16395) Also navigation.json Doc page should be hidden in sidebar, shown in top
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Also navigation.json Doc page should be hidden in sidebar, shown in top-menu when top-menu is displayed in the sidenav (hidden now).
Sure these could be separate PRs. Both changes are tiny. Let's get on with it.
Remember to run
yarn docs
locally as this PR changes docs andnavigation.json
.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")