Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aio): GaService should only send a tracking event if the path changes, net of # and ? #16442

Closed
wardbell opened this issue Apr 30, 2017 · 2 comments
Assignees

Comments

@wardbell
Copy link
Contributor

gkalpak: If necessary, also test that LocationService forwards the necessary "events" (see #15570 (comment)).

wardbell: I had arbitrarily decided to GA track in-page #frag clicks too and have no instructions to stop doing so.

Added PR #16441 which states this explicitly and confirms with a test. All we have to do is decide.

@petebacondarwin
Copy link
Member

We are now only sending a message to Google Analytics if the path changes, and not the hash or query.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants