New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aio): close sidenav in narrow (mobile) mode when select a new doc #16617
Conversation
54da337
to
fcaecd2
Compare
…cument closes angular#16603 As before this PR, when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
fcaecd2
to
cdae565
Compare
@@ -116,13 +116,18 @@ export class AppComponent implements OnInit { | |||
|
|||
this.navigationService.currentNode.subscribe(currentNode => { | |||
this.currentNode = currentNode; | |||
this.updateHostClasses(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to this PR, but it fixes another issue with styling applied prematurely (before the document is fetched). Maybe worth putting into a separate commit and test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed to let this request go and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…cument (angular#16617) closes angular#16603 As before this PR, when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
…cument (angular#16617) closes angular#16603 As before this PR, when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes #16603
This PR affects narrow (mobile) only. Now the sidenav closes when the current node (the current doc) changes.
Unchanged: when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")