New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(*) fix dangling links in API docs #16632
Merged
jasonaden
merged 7 commits into
angular:master
from
petebacondarwin:docs-fix-api-anchor-links
May 9, 2017
Merged
docs(*) fix dangling links in API docs #16632
jasonaden
merged 7 commits into
angular:master
from
petebacondarwin:docs-fix-api-anchor-links
May 9, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
comp: docs
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
May 8, 2017
The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`.
The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class.
petebacondarwin
force-pushed
the
docs-fix-api-anchor-links
branch
from
May 8, 2017 16:31
b317c17
to
abb3f9b
Compare
gkalpak
approved these changes
May 8, 2017
petebacondarwin
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
May 9, 2017
petebacondarwin
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
and removed
action: merge
The PR is ready for merge by the caretaker
labels
May 9, 2017
Waiting on a review for the various API areas... |
IgorMinar
approved these changes
May 9, 2017
IgorMinar
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
May 9, 2017
jasonaden
pushed a commit
to jasonaden/angular
that referenced
this pull request
May 10, 2017
* docs(animations): fix links to `Component` animations * docs(core): fix links to `ReflectiveInjector` methods The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`. * docs(core): fix links to `Renderer` The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class. * docs(router): fix links to methods * docs(forms): fix links to methods * docs(core): fix links to methods * docs(router): fix API page links and an internal link
smurfy
pushed a commit
to smurfy/angular
that referenced
this pull request
Jun 8, 2017
* docs(animations): fix links to `Component` animations * docs(core): fix links to `ReflectiveInjector` methods The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`. * docs(core): fix links to `Renderer` The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class. * docs(router): fix links to methods * docs(forms): fix links to methods * docs(core): fix links to methods * docs(router): fix API page links and an internal link
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
* docs(animations): fix links to `Component` animations * docs(core): fix links to `ReflectiveInjector` methods The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`. * docs(core): fix links to `Renderer` The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class. * docs(router): fix links to methods * docs(forms): fix links to methods * docs(core): fix links to methods * docs(router): fix API page links and an internal link
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
* docs(animations): fix links to `Component` animations * docs(core): fix links to `ReflectiveInjector` methods The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`. * docs(core): fix links to `Renderer` The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class. * docs(router): fix links to methods * docs(forms): fix links to methods * docs(core): fix links to methods * docs(router): fix API page links and an internal link
jmleoni
pushed a commit
to jmleoni/angular
that referenced
this pull request
Oct 6, 2018
* docs(animations): fix links to `Component` animations * docs(core): fix links to `ReflectiveInjector` methods The `resolve` and other methods were moved from the `Injector` to the `ReflectiveInjector`. * docs(core): fix links to `Renderer` The local links were assuming that that methods were on the current document (e.g. `RootRenderer`), but they are actually on the `Renderer` class. * docs(router): fix links to methods * docs(forms): fix links to methods * docs(core): fix links to methods * docs(router): fix API page links and an internal link
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
There are dangling links in the API docs.
What is the new behavior?
There are fewer (!) dangling links in the API docs.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: