New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(aio): create previews for all PRs that touch non-spec files in aio/
or packages/
#16733
Conversation
…o/` or `packages/` Previously, no previews would be deployed for PRs that didn't touch files inside `aio/`. Now, previews will be deployed for PRs that touch non-spec files inside either `aio/` or `packages/` (as long as other preconditions are met). Partially addresses angular#16526.
36480ad
to
4984745
Compare
@@ -4,21 +4,53 @@ | |||
set +x -eu -o pipefail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you turn off -x
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that it was +
, which is fine.
…o/` or `packages/` (angular#16733) Previously, no previews would be deployed for PRs that didn't touch files inside `aio/`. Now, previews will be deployed for PRs that touch non-spec files inside either `aio/` or `packages/` (as long as other preconditions are met). Partially addresses angular#16526.
…o/` or `packages/` (angular#16733) Previously, no previews would be deployed for PRs that didn't touch files inside `aio/`. Now, previews will be deployed for PRs that touch non-spec files inside either `aio/` or `packages/` (as long as other preconditions are met). Partially addresses angular#16526.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Previously, no previews would be deployed for PRs that didn't touch files inside
aio/
. Now, previews will be deployed for PRs that touch non-spec files inside eitheraio/
orpackages/
(as long as other preconditions are met).Partially addresses #16526.