Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(aio): create previews for all PRs that touch non-spec files in aio/ or packages/ #16733

Merged
merged 1 commit into from May 11, 2017

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented May 11, 2017

Previously, no previews would be deployed for PRs that didn't touch files inside aio/. Now, previews will be deployed for PRs that touch non-spec files inside either aio/ or packages/ (as long as other preconditions are met).

Partially addresses #16526.

…o/` or `packages/`

Previously, no previews would be deployed for PRs that didn't touch files inside
`aio/`. Now, previews will be deployed for PRs that touch non-spec files inside
either `aio/` or `packages/` (as long as other preconditions are met).

Partially addresses angular#16526.
@gkalpak gkalpak force-pushed the ci-aio-preview-more-stuff branch 2 times, most recently from 36480ad to 4984745 Compare May 11, 2017 20:24
@mary-poppins
Copy link

The angular.io preview for 88f74ed is available here.

@gkalpak gkalpak requested a review from IgorMinar May 11, 2017 20:38
@gkalpak gkalpak added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels May 11, 2017
@gkalpak gkalpak added this to REVIEW in docs-infra May 11, 2017
@mary-poppins
Copy link

The angular.io preview for 4984745 is available here.

@@ -4,21 +4,53 @@
set +x -eu -o pipefail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you turn off -x?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that it was +, which is fine.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 11, 2017
@IgorMinar IgorMinar merged commit decb4cc into angular:master May 11, 2017
@gkalpak gkalpak deleted the ci-aio-preview-more-stuff branch May 11, 2017 22:09
@gkalpak gkalpak removed this from REVIEW in docs-infra May 12, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…o/` or `packages/` (angular#16733)

Previously, no previews would be deployed for PRs that didn't touch files inside
`aio/`. Now, previews will be deployed for PRs that touch non-spec files inside
either `aio/` or `packages/` (as long as other preconditions are met).

Partially addresses angular#16526.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…o/` or `packages/` (angular#16733)

Previously, no previews would be deployed for PRs that didn't touch files inside
`aio/`. Now, previews will be deployed for PRs that touch non-spec files inside
either `aio/` or `packages/` (as long as other preconditions are met).

Partially addresses angular#16526.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants