Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Windows symlink scripts #16761

Merged
merged 1 commit into from Nov 2, 2017

Conversation

bisubus
Copy link
Contributor

@bisubus bisubus commented May 12, 2017

Fixes packages\upgrade\static\src symlink.

Closes #16760

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

See #16760

What is the new behavior?

packages\upgrade\static\src symbolic link behaves as expected on Windows.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@bisubus bisubus changed the title fix(build): update Windows symlink scripts build: update Windows symlink scripts May 12, 2017
@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label May 15, 2017
@jasonaden jasonaden requested review from jasonaden and mhevery and removed request for jasonaden May 15, 2017 18:20
@gkalpak
Copy link
Member

gkalpak commented Jul 4, 2017

@IgorMinar, @mhevery, could we get a LGTM here, please 😁

Fixes packages\upgrade\static\src symlink.

Closes angular#16760
@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 18, 2017
@gkalpak
Copy link
Member

gkalpak commented Sep 18, 2017

/ping @mhevery, @IgorMinar

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2017
@vicb vicb merged commit 613a9e3 into angular:master Nov 2, 2017
vicb pushed a commit that referenced this pull request Nov 2, 2017
Fixes packages\upgrade\static\src symlink.

Closes #16760
@gkalpak
Copy link
Member

gkalpak commented Nov 3, 2017

🎉

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages\upgrade\static\src symlink doesn't work on Windows
6 participants