build: import tslib rather than TS outputting #16901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
approved these changes
May 23, 2017
build.sh
Outdated
| @@ -125,7 +125,7 @@ downlevelES2015() { | |||
| cp ${file} ${ts_file} | |||
|
|
|||
| echo "====== $TSC ${ts_file} --target es5 --module es2015 --noLib" | |||
| ($TSC ${ts_file} --target es5 --module es2015 --noLib --sourceMap) > /dev/null 2>&1 || true | |||
| ($TSC ${ts_file} --target es5 --module es2015 --noLib --sourceMap --noEmitHelpers --importHelpers) > /dev/null 2>&1 || true | |||
There was a problem hiding this comment.
can you drop noEmitHelpers? in my testing it seems to be implied by importHelpers
IgorMinar
added
the
action: cleanup
jasonaden
added
action: merge
chuckjaz
approved these changes
May 23, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
jochenberger
reviewed
Oct 2, 2017
| 'rxjs/Subject': 'Rx', | ||
| } | ||
| plugins: [resolve()], | ||
| external: Object.keys(globals), |
There was a problem hiding this comment.
I'm not sure if that's correct. AFAICT, it should be ['@angular/core', 'rxjs']. Unfortunately, I haven't been able to run the angular build, so I couldn't verify the change yet.
jmleoni
pushed a commit
to jmleoni/angular
that referenced
this pull request
Oct 6, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.