Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the release schedule #16942

Merged
merged 1 commit into from May 23, 2017
Merged

docs: update the release schedule #16942

merged 1 commit into from May 23, 2017

Conversation

vicb
Copy link
Contributor

@vicb vicb commented May 22, 2017

No description provided.

@vicb vicb requested a review from IgorMinar May 22, 2017 23:56
@vicb vicb added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2017
IgorMinar
IgorMinar suggested changes May 23, 2017
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of nitpicks, the rest looks great. thanks!

docs/RELEASE_SCHEDULE.md Outdated
*2017-03-17* | | *4.0.0-rc.5* | *Unplanned release to fix compiler-cli dependency version*
2017-03-22 | 4.0.0 + 2.4.12 | - | Major Version Release

2017-05-1 | 4.1.1 | 4.2.0-beta.0 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: can you add leading 0 in days

docs/RELEASE_SCHEDULE.md Outdated
2017-08-28 | 4.3.10 | 5.0.0-rc.0 |
2017-09-4 | 4.3.11 | 5.0.0-rc.1 |
2017-09-11 | 4.3.12 | 5.0.0-rc.2 |
2017-09-18 | 5.0.0 + 4.3.13 | - | Major Version Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop 4.3.13 please? usually we get so busy around the major release that we don't have the cycles to cut a patch. Besides there is rarely anything to be cherry-picked to stable release during the RC of a major.

docs/RELEASE_SCHEDULE.md Outdated
2017-07-10 | 4.3.3 | 5.0.0-beta.2 |
2017-07-17 | 4.3.4 | 5.0.0-beta.3 |
2017-07-24 | 4.3.5 | 5.0.0-beta.4 |
2017-07-31 | 4.3.6 | 5.0.0-beta.5 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you align the | symbols for columns please?

docs/RELEASE_SCHEDULE.md Outdated
2017-08-28 | 4.3.10 | 5.0.0-rc.0 |
2017-09-4 | 4.3.11 | 5.0.0-rc.1 |
2017-09-11 | 4.3.12 | 5.0.0-rc.2 |
2017-09-18 | 5.0.0 + 4.3.13 | - | Major Version Release

## Tentative Schedule After March 2017
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to "After September" and remove 5.0.0 from the list below?

@vicb vicb force-pushed the 0522-schedule branch 3 times, most recently from 75783fe to 09ef8a9 Compare May 23, 2017 00:13
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 23, 2017
@chuckjaz chuckjaz merged commit 78e3be1 into angular:master May 23, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@vicb
docs: update the release schedule (angular#16942)
00a70ce
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@vicb @juleskremer
docs: update the release schedule (angular#16942)
d4f3203
@vicb vicb deleted the 0522-schedule branch March 6, 2018 22:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicb @IgorMinar @chuckjaz @googlebot