Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aio): group topbar into a single sidenav node when narrow #17001

Merged
merged 1 commit into from May 25, 2017
Merged

fix(aio): group topbar into a single sidenav node when narrow #17001

merged 1 commit into from May 25, 2017

Conversation

petebacondarwin
Copy link
Member

No description provided.

@petebacondarwin petebacondarwin added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels May 24, 2017
@mary-poppins
Copy link

The angular.io preview for 9f3a2de is available here.

@gkalpak
Copy link
Member

gkalpak commented May 24, 2017

I like it (except for the fact that other than Features all other subitems are not highlighted and expanded when selected 😕)

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra May 25, 2017
@petebacondarwin
fix(aio): group topbar items into a single sidenav node when narrow s…
1030a35 
…creen

The `TopBarNarrow` now only shows a single top level container, "About Angular",
and the original `TopBar` items will be children of this container.

The `TopBarNarrow` styling is changed to match the rest of the `SideNav`.
@mary-poppins
Copy link

The angular.io preview for 1030a35 is available here.

@petebacondarwin
Copy link
Member Author

petebacondarwin commented May 25, 2017 •
edited

I like it (except for the fact that other than Features all other subitems are not highlighted and expanded when selected 😕)

The reason for this is that those nodes also appear in the Footer nav view, and that seems to get precedence. So they don't get highlighted in the TopBarNarrow nav view.

I created an issue - #17022 - and will fix in a subsequent PR.

@petebacondarwin
Copy link
Member Author

@IgorMinar - I have removed the "Docs" item from the "TopBarNarrow" view as requested. PTAL.

@IgorMinar IgorMinar self-requested a review May 25, 2017 22:45
IgorMinar
IgorMinar approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! thanks

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 25, 2017
@chuckjaz chuckjaz merged commit 2538094 into angular:master May 25, 2017
@petebacondarwin petebacondarwin deleted the aio-narrow-sidenav branch May 26, 2017 05:00
@petebacondarwin petebacondarwin removed this from REVIEW in docs-infra May 26, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@petebacondarwin
fix(aio): group topbar items into a single sidenav node when narrow s…
73c9df4 
…creen (angular#17001)

The `TopBarNarrow` now only shows a single top level container, "About Angular",
and the original `TopBar` items will be children of this container.

The `TopBarNarrow` styling is changed to match the rest of the `SideNav`.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@petebacondarwin @juleskremer
fix(aio): group topbar items into a single sidenav node when narrow s…
ffdc771 
…creen (angular#17001)

The `TopBarNarrow` now only shows a single top level container, "About Angular",
and the original `TopBar` items will be children of this container.

The `TopBarNarrow` styling is changed to match the rest of the `SideNav`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@petebacondarwin @mary-poppins @gkalpak @IgorMinar @chuckjaz @googlebot