Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aio): update the home page and docs landing page content #17325

Merged
merged 1 commit into from
Jun 8, 2017
Merged

feat(aio): update the home page and docs landing page content #17325

merged 1 commit into from
Jun 8, 2017

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar requested a review from gkalpak June 8, 2017 08:27
@IgorMinar IgorMinar added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 8, 2017
@mary-poppins
Copy link

The angular.io preview for 29fd294 is available here.

@mary-poppins
Copy link

The angular.io preview for 5b440a6 is available here.

gkalpak
gkalpak reviewed Jun 8, 2017
View reviewed changes
aio/content/navigation.json
},
{
"url": "https://blog.angularjs.org/",
"title": "Blog"
Copy link
Member

@gkalpak gkalpak Jun 8, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in TopBarNarrow as well (to be shown in SideNav on small screens)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gkalpak
Copy link
Member

gkalpak commented Jun 8, 2017

(I have been posting comments on wrong issues - Sorry)
So, this fails on Travis because of old Chromum version.

@mary-poppins
Copy link

The angular.io preview for e862849 is available here.

@IgorMinar IgorMinar force-pushed the aio-content-update branch 2 times, most recently from d580d85 to 890b7ed Compare June 8, 2017 19:12
robwormald
robwormald reviewed Jun 8, 2017
View reviewed changes
aio/content/marketing/docs.md Outdated
@@ -5,8 +5,8 @@ Angular is a platform that makes it easy to build applications with the web. Ang
<div class="card-container">
<a href="generated/live-examples/quickstart/eplnkr.html" target="_blank" class="docs-card"
title="Experience Angular in a live coding environment">
<section>Experience Angular</section>
<p>A quick look at an Angular application.</p>
<section>Get a Glimps of Angular</section>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: Glimpse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch :)

@mary-poppins
Copy link

The angular.io preview for a943858 is available here.

gkalpak
gkalpak approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as Travis is happy.

One side effect of this is that the search-box is shorter than it used to be when expanded, because is it a percentage of the remaining top-bar space. Not sure if it needs to be addressed or not and certainly doesn't have to be part of this PR.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 8, 2017
@IgorMinar IgorMinar merged commit 576d6d8 into angular:master Jun 8, 2017
@gkalpak gkalpak mentioned this pull request Jun 9, 2017
Closed
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@IgorMinar
feat(aio): update the home page and docs landing page content (angula…
8860561 
…r#17325)

Closes angular#17268
Closes angular#17230
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@IgorMinar @juleskremer
feat(aio): update the home page and docs landing page content (angula…
1b928b9 
…r#17325)

Closes angular#17268
Closes angular#17230
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robwormald robwormald robwormald left review comments

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IgorMinar @mary-poppins @gkalpak @robwormald @googlebot