Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS is removing support for /deep/ #17557

Closed
zoechi opened this issue Jun 16, 2017 · 11 comments
Closed

SASS is removing support for /deep/ #17557

zoechi opened this issue Jun 16, 2017 · 11 comments

Comments

@zoechi
Copy link
Contributor

zoechi commented Jun 16, 2017

I'm submitting a ...


[ ] Regression (behavior that used to work and stopped working in a new release)
[ ] Bug report 
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Expected behavior

See also

I don't know if node-sass will keep supporting it or what SASS version Angular TS developers might use.

just to be sure it's on your radar

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX 
- Platform: 

Others:

@hansl
Copy link
Contributor

hansl commented Jun 20, 2017

Labeling this as aio because they're the only ones using sass in this repo. Thanks!

@zoechi
Copy link
Contributor Author

zoechi commented Jun 20, 2017

@hansl This affects all Angular users that use SASS with Angular (at least if they use dart-sass or when /deep/ support will be removed from other SASS implementations)

@hansl
Copy link
Contributor

hansl commented Jun 20, 2017

We'll see how long it takes node-sass to catch up with this. I'm sending this issue to devrel to see if there's anything we can do. Thanks!

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Jun 21, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to TODO in docs-infra Jun 21, 2017
@petebacondarwin
Copy link
Member

There are references to /deep/ in the component-styles page (don't look at the Table of Contents layout problem - it is being fixed).

Ping @wardbell who has had a hand in that doc.

@petebacondarwin
Copy link
Member

But we are not using it in the aio app itself.

@zoechi
Copy link
Contributor Author

zoechi commented Jun 21, 2017

@hansl please also check the links in my initial comment. The Dart Angular and the SASS team agreed on a replacement.

@hansl
Copy link
Contributor

hansl commented Jun 21, 2017

For those looking around, the replacement suggested by the AngularDart team is ::ng-deep and it's specific to AngularDart, not SASS itself.

@Ketec
Copy link

Ketec commented Jun 22, 2017

That would be quite disasterous. There is a massive number of third party modules i cannot just go and edit to use alternative replacements.

@zoechi
Copy link
Contributor Author

zoechi commented Jun 22, 2017

@Ketec this is why I created the issue, so that there is time to react.

@IgorMinar
Copy link
Contributor

this was resolved via b754e60

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants