Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(aio): architecture review for a11y #17848

Closed
wants to merge 1 commit into from
Closed

docs(aio): architecture review for a11y #17848

wants to merge 1 commit into from

Conversation

Foxandxss
Copy link
Member

Labels are not "blocks" so there is the need for a

The global css should be revised for forms.

@mary-poppins
Copy link

You can preview 387ccfb at https://pr17848-387ccfb.ngbuilds.io/.

@IgorMinar IgorMinar added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 11, 2017
@wardbell wardbell added this to Merge in docs Aug 15, 2017
@wardbell wardbell moved this from Merge to Review in docs Aug 15, 2017
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@mary-poppins
Copy link

You can preview 11fcdaf at https://pr17848-11fcdaf.ngbuilds.io/.

@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • target label
  • merge label
  • green CI

wardbell
wardbell approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and urgent to get aligned with v.5
We can do more polishing later

@Foxandxss Foxandxss removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 2, 2017
@ocombe ocombe added the target: patch This PR is targeted for the next patch release label Nov 13, 2017
@IgorMinar
Copy link
Contributor

@Foxandxss this was never labeled for merge. Can I go ahead and get it merged? Or does it need to be updated?

@Foxandxss Foxandxss added the action: merge The PR is ready for merge by the caretaker label Dec 1, 2017
IgorMinar pushed a commit that referenced this pull request Dec 6, 2017
@Foxandxss @IgorMinar
docs(aio): architecture review for a11y (#17848)
6d15dd7 
PR Close #17848
@IgorMinar IgorMinar closed this in f7328c6 Dec 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wardbell wardbell wardbell approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
No open projects
docs
  
Review
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Foxandxss @mary-poppins @vicb @IgorMinar @wardbell @ocombe @googlebot