fix(compiler-cli): fix relative source paths on windows for extracted msg #17915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
area: i18n
action: review
ocombe
force-pushed
the
fix-source-path-16639
branch
from
af72887
to
52cf473
Compare
|
Could you update the commit message to reflect what the change fix ? (ie "fix relative path on windows" maybe) |
vicb
previously requested changes
Jul 5, 2017
ocombe
force-pushed
the
fix-source-path-16639
branch
from
52cf473
to
5efe56e
Compare
ocombe
changed the title
vicb
approved these changes
Jul 6, 2017
vicb
added
action: merge
|
aio failure is unrelated to this change |
|
You can preview 5efe56e at https://pr17915-5efe56e.ngbuilds.io/. |
jasonaden
pushed a commit
that referenced
this pull request
Jul 8, 2017
jasonaden
pushed a commit
to jasonaden/angular
that referenced
this pull request
Jul 8, 2017
jasonaden
pushed a commit
to jasonaden/angular
that referenced
this pull request
Jul 8, 2017
jasonaden
pushed a commit
to jasonaden/angular
that referenced
this pull request
Jul 8, 2017
ocombe
changed the title
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The extracted source file paths was supposed to be relative, but we used a simple replace that doesn't work on windows (because we used two paths formatted differently), and the path was absolute instead of relative.
Issue Number: #16639
What is the new behavior?
The paths are relative on all platforms
Does this PR introduce a breaking change?