Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a warning when an :enter query is used inside of an :enter (or void => *) transition #18173

Closed
matsko opened this issue Jul 17, 2017 · 2 comments

Comments

@matsko
Copy link
Contributor

matsko commented Jul 17, 2017

When an element is inserted into the view the inner elements are not queryable using :enter because :enter queries are only for root-level. So when an enter transition kicks off it, by definition, is a container being inserted and, therefore, is root-level.

This means that if an animation trigger contains a * => * transition and that transition contains :enter or :leave queries then it will throw an error (since the queries return nothing).

What should happen is that animations should throw an error when :enter is used inside of an :enter transition and/or if a :leave query is used inside of a :leave transition.

@matsko
Copy link
Contributor Author

matsko commented Oct 31, 2017

No need for this as #19455 should handle the problem.

@matsko matsko closed this as completed Oct 31, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants