Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTER.md): fixed link #18228

Merged
merged 1 commit into from Jul 20, 2017
Merged

docs(CONTRIBUTER.md): fixed link #18228

merged 1 commit into from Jul 20, 2017

Conversation

benceHornyak
Copy link
Contributor

@benceHornyak benceHornyak commented Jul 19, 2017

docs/COMMITER.md now points correctly to CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Gives 404 - Page not found
Issue Number: N/A

What is the new behavior?

Navigates to CONTRIBUTING.md file

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

 The link to the CONTRIBUTING.md file was not correct
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@benceHornyak
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Jul 19, 2017

Thx, @hornyakbence! Can you please amend the commit and update the commit message, so that it follows our guidelines? (E.g. docs: fix link in COMMITTER.md)

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jul 19, 2017
@mhevery mhevery merged commit 8de44cf into angular:master Jul 20, 2017
mhevery pushed a commit that referenced this pull request Jul 26, 2017
The link to the CONTRIBUTING.md file was not correct
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
The link to the CONTRIBUTING.md file was not correct
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
The link to the CONTRIBUTING.md file was not correct
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
The link to the CONTRIBUTING.md file was not correct
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants