Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng_module for core #18289

Closed
wants to merge 2 commits into from
Closed

ng_module for core #18289

wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@mary-poppins
Copy link

You can preview 84e0b25 at https://pr18289-84e0b25.ngbuilds.io/.

Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert all of the changes in the shrinkwrap which are not needed.

@alexeagle alexeagle force-pushed the bazel2 branch 2 times, most recently from ffa9265 to 92cc157 Compare July 21, 2017 22:08
@alexeagle
Copy link
Contributor Author

@mhevery fixed the shrinkwrap file in vim
:%s/,\n\s*"optional": true//
:%s/,\n\s*"dev": true//

@mary-poppins
Copy link

You can preview ffa9265 at https://pr18289-ffa9265.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 92cc157 at https://pr18289-92cc157.ngbuilds.io/.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Jul 21, 2017
@alexeagle alexeagle force-pushed the bazel2 branch 2 times, most recently from 30c85d7 to c1dc4ec Compare July 21, 2017 22:58
@mary-poppins
Copy link

You can preview c1dc4ec at https://pr18289-c1dc4ec.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ac3f127 at https://pr18289-ac3f127.ngbuilds.io/.

mhevery pushed a commit that referenced this pull request Jul 21, 2017
@mhevery mhevery closed this in 6fc5940 Jul 21, 2017
mhevery pushed a commit that referenced this pull request Jul 26, 2017
mhevery pushed a commit that referenced this pull request Jul 26, 2017
mhevery added a commit that referenced this pull request Jul 27, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants