Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ngc-wrapped): fix broken bazel build #18335

Merged
merged 1 commit into from Jul 26, 2017
Merged

fix(ngc-wrapped): fix broken bazel build #18335

merged 1 commit into from Jul 26, 2017

Conversation

adeora
Copy link
Contributor

@adeora adeora commented Jul 25, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Bazel build doesn't work properly

Issue Number: N/A

What is the new behavior?

Bazel build works properly

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vikerman vikerman requested a review from chuckjaz July 25, 2017 23:37
@vikerman vikerman added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 25, 2017
@vikerman vikerman requested a review from IgorMinar July 25, 2017 23:38
chuckjaz
chuckjaz suggested changes Jul 25, 2017
View reviewed changes
tools/ngc-wrapped/index.ts Outdated
@@ -18,7 +18,7 @@ function main(args: string[]) {
const [{options, bazelOpts, files, config}] = parseTsconfig(args[1]);
const ngOptions: {expectedOut: string[]} = (config as any).angularCompilerOptions;

const result = ngc(args, undefined, files, options, ngOptions);
const result = ngc(args, undefined);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to use the the new API instead.

@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 26, 2017
@mhevery mhevery merged commit 205abe8 into angular:master Jul 26, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@adeora
build: fix broken bazel build (angular#18335)
468a3ee
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@adeora @juleskremer
build: fix broken bazel build (angular#18335)
56e5bfb
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@adeora @juleskremer
build: fix broken bazel build (angular#18335)
1236b4c
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@chuckjaz chuckjaz chuckjaz approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adeora @mhevery @chuckjaz @vikerman @googlebot