refactor(forms): move value accessor tests into own spec #18356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
the
action: review
kara
changed the title
tinayuangao
approved these changes
Jul 26, 2017
| import {By} from '@angular/platform-browser/src/dom/debug/by'; | ||
| import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter'; | ||
| import {dispatchEvent} from '@angular/platform-browser/testing/src/browser_util'; | ||
| import {timer} from 'rxjs/observable/timer'; | ||
| import {_do} from 'rxjs/operator/do'; | ||
| import {MyInput, MyInputForm} from './value_accessor_integration_spec'; |
There was a problem hiding this comment.
Are these used in this file?
There was a problem hiding this comment.
The diff is misleading because I'm removing one of the usages, but the symbols are still used on line 480: https://github.com/kara/angular/blob/c52e8e9ca1e34ec7e320888e988495d86a0d3377/packages/forms/test/reactive_integration_spec.ts#L481
kara
added
action: merge
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply cleans up the organization of the forms tests so they're easier to scan. The integration specs were getting way too long to use effectively, so there is now a separate value accessor integration spec.