New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-cli): modified ngc to throw all errors, not just syntax #18388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
approved these changes
Jul 27, 2017
1 task
vicb
added
area: core
Issues related to the framework runtime
flag: can be closed?
labels
Aug 3, 2017
ocombe
pushed a commit
to ocombe/angular
that referenced
this pull request
Aug 5, 2017
chuckjaz
added a commit
to chuckjaz/angular
that referenced
this pull request
Aug 7, 2017
Fixes issue uncovered by angular#18388 and re-enables expression lowering disabled by angular#18513.
chuckjaz
added a commit
to chuckjaz/angular
that referenced
this pull request
Aug 8, 2017
Fixes issue uncovered by angular#18388 and re-enables expression lowering disabled by angular#18513.
vicb
pushed a commit
that referenced
this pull request
Aug 8, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
Fixes issue uncovered by angular#18388 and re-enables expression lowering disabled by angular#18513.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
Fixes issue uncovered by angular#18388 and re-enables expression lowering disabled by angular#18513.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
Fixes issue uncovered by angular#18388 and re-enables expression lowering disabled by angular#18513.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: core
Issues related to the framework runtime
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
ngc's performCompilation method now throws all errors, not just syntax errors
What is the current behavior?
ngc's performCompilation method only throws syntax errors, with others silently being caught
Issue Number: N/A
What is the new behavior?
ngc's performCompilation method now throws all errors, not just syntax errors
Does this PR introduce a breaking change?
Other information