Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): modified ngc to throw all errors, not just syntax #18388

Merged
merged 1 commit into from Aug 3, 2017

Conversation

adeora
Copy link
Contributor

@adeora adeora commented Jul 27, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

ngc's performCompilation method now throws all errors, not just syntax errors

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

ngc's performCompilation method only throws syntax errors, with others silently being caught

Issue Number: N/A

What is the new behavior?

ngc's performCompilation method now throws all errors, not just syntax errors

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vicb vicb added area: core Issues related to the framework runtime flag: can be closed? labels Aug 3, 2017
@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2017
@vicb vicb added the target: major This PR is targeted for the next major release label Aug 3, 2017
@vicb vicb merged commit 5651e4a into angular:master Aug 3, 2017
chuckjaz added a commit to chuckjaz/angular that referenced this pull request Aug 7, 2017
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
chuckjaz added a commit to chuckjaz/angular that referenced this pull request Aug 8, 2017
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
vicb pushed a commit that referenced this pull request Aug 8, 2017
Fixes issue uncovered by #18388 and re-enables expression
lowering disabled by #18513.
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants