Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): resolve error when using AnimationBuilder with platf… #18642

Closed
wants to merge 1 commit into from
Closed

fix(animations): resolve error when using AnimationBuilder with platf… #18642

wants to merge 1 commit into from

Conversation

vikerman
Copy link
Contributor

…orm-server

Use an injected DOCUMENT instead of assuming the global 'document'
exists.

Fixes #18635.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Exception when AnimationBuilder is injected on the server.

Issue Number: #18635

What is the new behavior?

No Exceptions

Does this PR introduce a breaking change?

[ ] Yes
[x] No

…orm-server

Use an injected DOCUMENT instead of assuming the global 'document'
exists.

Fixes #18635.
@mary-poppins
Copy link

You can preview 5b998e5 at https://pr18642-5b998e5.ngbuilds.io/.

@vikerman vikerman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 16, 2017
@mhevery mhevery closed this in 845c68f Aug 17, 2017
mhevery pushed a commit that referenced this pull request Aug 17, 2017
…orm-server (#18642)

Use an injected DOCUMENT instead of assuming the global 'document'
exists.

Fixes #18635.

PR Close #18642
mhevery pushed a commit that referenced this pull request Aug 18, 2017
…orm-server (#18642)

Use an injected DOCUMENT instead of assuming the global 'document'
exists.

Fixes #18635.

PR Close #18642
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using AnimationBuilder breaks Universal "document is not defined"
5 participants