Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aio: Clarify docs on use of entryComponent #18957

Closed
DeborahK opened this issue Aug 30, 2017 · 3 comments
Closed

aio: Clarify docs on use of entryComponent #18957

DeborahK opened this issue Aug 30, 2017 · 3 comments

Comments

@DeborahK
Copy link
Contributor

DeborahK commented Aug 30, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Current doc text:
"Most application components are loaded declaratively. Angular uses the component's selector to locate the element in the template. It then creates the HTML representation of the component and inserts it into the DOM at the selected element. These aren't entry components."

Expected behavior

Recommend changing the first sentence to simply say: "Application components can be loaded declaratively".

Minimal reproduction of the problem with instructions

Link to the doc section is here:
https://angular.io/guide/ngmodule-faq#what-is-an-entry-component

What is the motivation / use case for changing the behavior?

I disagree that "most application components are loaded declaratively". This implies that most application components are used as nested (child) components. In many applications, the majority of the components maybe be routed instead.

Stating that "most" components are nested (child) components assumes a composition-based application architecture that many devs may not be using.

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@kapunahelewong
Copy link
Contributor

Hi @DeborahK!! Since there's now a new doc just on entry components, would you mind if I closed this?

@DeborahK
Copy link
Contributor Author

Yes. Thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
docs
  
Awaiting triage
Development

No branches or pull requests

3 participants