fix(tsc-wrapped): decouple bundle index host from tsickle dependency #18999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
reviewed
Sep 1, 2017
| @@ -0,0 +1,19 @@ | |||
| /** | |||
There was a problem hiding this comment.
Maybe rename to index_no_tsickle?
tbosch
reviewed
Sep 1, 2017
| @@ -0,0 +1,61 @@ | |||
| /** | |||
There was a problem hiding this comment.
Maybe rename to main_no_tsickle?
tbosch
approved these changes
Sep 1, 2017
alexeagle
force-pushed
the
no_tsickle
branch
2 times, most recently
from
b9b1654
to
16993ca
Compare
|
You can preview 16993ca at https://pr18999-16993ca.ngbuilds.io/. |
alexeagle
force-pushed
the
no_tsickle
branch
from
16993ca
to
e10b5ac
Compare
alexeagle
force-pushed
the
no_tsickle
branch
from
e10b5ac
to
c40b519
Compare
|
You can preview e10b5ac at https://pr18999-e10b5ac.ngbuilds.io/. |
|
You can preview c40b519 at https://pr18999-c40b519.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks a refactoring in google3