Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): update template parse error message to ng-template #19029

Closed
wants to merge 1 commit into from
Closed

fix(compiler): update template parse error message to ng-template #19029

wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Sep 4, 2017

PR Type

What kind of change does this PR introduce?

[x] Refactoring (no functional changes, no api changes)

What is the current behavior?

I forgot to update an error message when I updated template to ng-template

What is the new behavior?

Message updated

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Sep 4, 2017
@ocombe ocombe requested a review from mhevery September 4, 2017 12:09
@mary-poppins
Copy link

You can preview 8bbf721 at https://pr19029-8bbf721.ngbuilds.io/.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Sep 5, 2017
@mhevery mhevery closed this in b56dd32 Sep 6, 2017
@ocombe ocombe deleted the fix-let-deprecated-comment branch September 11, 2017 08:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocombe @mary-poppins @mhevery @googlebot