Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(aio): render constructor overloads for API docs #19042

Merged
merged 1 commit into from
Sep 6, 2017
Merged

build(aio): render constructor overloads for API docs #19042

merged 1 commit into from
Sep 6, 2017

Conversation

petebacondarwin
Copy link
Member

Sits on top of #18927, which should be merged first.

@petebacondarwin petebacondarwin added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 4, 2017
@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Sep 4, 2017
@mary-poppins
Copy link

You can preview 8a750f1 at https://pr19042-8a750f1.ngbuilds.io/.

@petebacondarwin
Copy link
Member Author

You can see an example here: https://goo.gl/mPWTpW

@gkalpak gkalpak added state: blocked and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 5, 2017
@gkalpak gkalpak moved this from REVIEW to MERGE in docs-infra Sep 5, 2017
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed state: blocked labels Sep 6, 2017
@gkalpak
Copy link
Member

gkalpak commented Sep 6, 2017

@petebacondarwin, this needs rebasing (#18927 has been merged).

@petebacondarwin petebacondarwin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 6, 2017
@petebacondarwin
Copy link
Member Author

Rebased. Merge when green, please.

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Sep 6, 2017
@mary-poppins
Copy link

You can preview fede142 at https://pr19042-fede142.ngbuilds.io/.

@mhevery mhevery merged commit 3c480e4 into angular:master Sep 6, 2017
@gkalpak gkalpak removed this from MERGE in docs-infra Sep 6, 2017
@petebacondarwin petebacondarwin deleted the aio-constructor-overloads branch September 11, 2017 06:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petebacondarwin @mary-poppins @gkalpak @mhevery @googlebot