Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(common): don't generate tsickle re-export file for locales package #19135

Closed
wants to merge 1 commit into from
Closed

build(common): don't generate tsickle re-export file for locales package #19135

wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Sep 11, 2017

PR Type

What kind of change does this PR introduce?

[x] Build related changes

What is the current behavior?

We generate a re-export file for the i18n locales package, but this package has no index and the re-export file points to a inexistent file.

What is the new behavior?

We don't generate this re-export file for the locales package

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added area: i18n action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 11, 2017
@alexeagle
Copy link
Contributor

Needs an @IgorMinar Stamp of Approval

@ocombe ocombe removed the request for review from vicb September 11, 2017 14:07
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 19, 2017
@IgorMinar
Copy link
Contributor

can you please rebase?

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Sep 20, 2017
@ocombe
Copy link
Contributor Author

ocombe commented Sep 21, 2017

Rebased!

@ocombe ocombe added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 21, 2017
@IgorMinar IgorMinar closed this in 6e1896b Sep 21, 2017
@ocombe ocombe deleted the fix-locales-build branch November 10, 2017 08:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees

@IgorMinar IgorMinar

Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocombe @alexeagle @IgorMinar @googlebot