refactor(upgrade): use correct property name #19180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make any difference in this case, because the we only check the property for truthfulness (and being undefined has the same effect as being set to false).
gkalpak
added
comp: upgrade/dynamic
action: review
|
You can preview 8e95a37 at https://pr19180-8e95a37.ngbuilds.io/. |
petebacondarwin
approved these changes
Sep 13, 2017
petebacondarwin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
Wrong property name used.
What is the new behavior?
Correct property name used.
Does this PR introduce a breaking change?
Other information
It doesn't make any difference in this case, because the we only check the property for truthfulness (and being undefined has the same effect as being set to false).