test: fix cli-integration tests that got broken by yarn update #19297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
added
action: review
alexeagle
approved these changes
Sep 20, 2017
|
this didn't work :-( I'll have to investigate more |
|
Consider rolling back the breaking commit?
…On Wed, Sep 20, 2017 at 11:29 AM Igor Minar ***@***.***> wrote:
this didn't work :-( I'll have to investigate more
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#19297 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I7--rSJd1kmUIZ4zyrmkhvKFc_eaks5skVlwgaJpZM4PePxe>
.
|
previously we relied on yarn creating a new project/package.json in the current dirrectory, which is incorrect. this change inits the project before installing the cli.
IgorMinar
force-pushed
the
fix-cli-integration-tests
branch
from
da2f7d4
to
4ab0403
Compare
IgorMinar
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we relied on yarn creating a new project/package.json in the current dirrectory,
which is incorrect. this change inits the project before installing the cli.