Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(aio): ensure decorators with shared interface types are found #19361

Merged
merged 1 commit into from Sep 25, 2017
Merged

build(aio): ensure decorators with shared interface types are found #19361

merged 1 commit into from Sep 25, 2017

Conversation

petebacondarwin
Copy link
Member

Closes #19358

@petebacondarwin petebacondarwin added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 24, 2017
@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Sep 24, 2017
@mary-poppins
Copy link

You can preview 9ec13ad at https://pr19361-9ec13ad.ngbuilds.io/.

@petebacondarwin
Copy link
Member Author

See https://pr19361-9ec13ad.ngbuilds.io/api?query=child&type=decorator

gkalpak
gkalpak approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 25, 2017
@gkalpak gkalpak moved this from REVIEW to MERGE in docs-infra Sep 25, 2017
@vicb vicb merged commit 4ae546b into angular:master Sep 25, 2017
vicb pushed a commit that referenced this pull request Sep 25, 2017
@petebacondarwin @vicb
build(aio): ensure decorators with shared interface types are found (#…
5f9a10a 
…19361)

Closes #19358
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Sep 25, 2017
@petebacondarwin petebacondarwin deleted the aio-query-decorator-processing branch October 9, 2017 12:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorators aren't listed as such in API documentation
5 participants
@petebacondarwin @mary-poppins @gkalpak @vicb @googlebot