Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(aio): remove -- from more yarn commands #19421

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Sep 26, 2017

PR Checklist

PR Type

[x] Build related changes

What is the current behavior?

Yarn commands unnecessarily invoked with --.

What is the new behavior?

Yarn commands invoked without --.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@gkalpak gkalpak added comp: aio area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 26, 2017
@gkalpak gkalpak added this to REVIEW in docs-infra Sep 26, 2017
@mary-poppins
Copy link

You can preview 1088175 at https://pr19421-1088175.ngbuilds.io/.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 28, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Sep 28, 2017
@petebacondarwin
Copy link
Member

Will there be another PR for stable?

@gkalpak
Copy link
Member Author

gkalpak commented Sep 28, 2017

That was the plan 😃 This doesn't merge cleanly into stable, because the run-example-e2e script has changed. I was waiting for #19369 to see what's left to remove across the whole repo.

@vicb vicb merged commit f7199aa into angular:master Sep 28, 2017
@gkalpak gkalpak deleted the build-aio-remove-- branch September 28, 2017 19:36
@gkalpak gkalpak removed this from MERGE in docs-infra Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants