-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(aio): fix testing of NgPackagesInstaller
and bring up-to-date with 4.4.x version
#19655
Conversation
You can preview db01c51 at https://pr19655-db01c51.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also fix up the devDependencies
in locally built packages too.
LGTM otherwise
Good catch! PTAL. |
You can preview 848c1da at https://pr19655-848c1da.ngbuilds.io/. |
Of course, now the last commit will need to be backported to 4.4.x 🙀 |
…n other local ones
848c1da
to
dd4fc1d
Compare
You can preview dd4fc1d at https://pr19655-dd4fc1d.ngbuilds.io/. |
Backported in #19687. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR "foreports" the changes made to
NgPackagesInstaller
in #19600. These include:tsc-wrapped
was built indist/tools/@angular/
instead ofdist/packages-dist/
).compiler-cli
used to depend ontsc-wrapped
). By "depend directly", I mean asdependencies
, notpeerDependencies
.(Note: The new features are not necessary for master atm, but could become necessary in the future.)