Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(aio): fix testing of NgPackagesInstaller and bring up-to-date with 4.4.x version #19655

Closed
wants to merge 2 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 11, 2017

This PR "foreports" the changes made to NgPackagesInstaller in #19600. These include:

  1. Fixing some tests and make sure the tests are run on CI (previously they weren't).
  2. Bring the two implementations closer (so that future maintainance is easier). This adds two new features:
    1. Be able to look into more directories for local Angular packages (e.g. previously tsc-wrapped was built in dist/tools/@angular/ instead of dist/packages-dist/).
    2. Be able to handle local Angular packages that depend directly on other local Angular packages (e.g. previously compiler-cli used to depend on tsc-wrapped). By "depend directly", I mean as dependencies, not peerDependencies.

(Note: The new features are not necessary for master atm, but could become necessary in the future.)

@gkalpak gkalpak added comp: aio area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 11, 2017
@gkalpak gkalpak added this to REVIEW in docs-infra Oct 11, 2017
@mary-poppins
Copy link

You can preview db01c51 at https://pr19655-db01c51.ngbuilds.io/.

Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also fix up the devDependencies in locally built packages too.
LGTM otherwise

@gkalpak
Copy link
Member Author

gkalpak commented Oct 11, 2017

Good catch! PTAL.

@mary-poppins
Copy link

You can preview 848c1da at https://pr19655-848c1da.ngbuilds.io/.

@petebacondarwin
Copy link
Member

Of course, now the last commit will need to be backported to 4.4.x 🙀

@petebacondarwin petebacondarwin added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 12, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Oct 12, 2017
@mary-poppins
Copy link

You can preview dd4fc1d at https://pr19655-dd4fc1d.ngbuilds.io/.

@gkalpak
Copy link
Member Author

gkalpak commented Oct 12, 2017

Backported in #19687.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 12, 2017
@tbosch tbosch added this to the Merge-queue milestone Oct 12, 2017
@tbosch tbosch closed this in 62c7b78 Oct 13, 2017
tbosch pushed a commit that referenced this pull request Oct 13, 2017
@gkalpak gkalpak deleted the build-aio-fix-instaler branch October 13, 2017 18:48
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Oct 13, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants