Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: narrow TS version to >=2.4.2 and <2.5 #19787

Closed
wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Oct 18, 2017

As this is the only version range that we tested against in G3.
We will support newer versions of TypeScript soon
after the Angular 5 release.

Closes #19750

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

As this is the only version range that we tested against in G3.
We will support newer versions of TypeScript soon 
after the Angular 5 release.

Closes angular#19750
@tbosch tbosch added area: packaging Issues related to Angular's creation of npm packages target: major This PR is targeted for the next major release and removed cla: yes labels Oct 18, 2017
@mary-poppins
Copy link

You can preview 5103486 at https://pr19787-5103486.ngbuilds.io/.

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2017
@tbosch tbosch requested a review from IgorMinar October 18, 2017 18:12
@tbosch tbosch closed this in b922743 Oct 18, 2017
@tbosch tbosch deleted the lock_ts branch October 19, 2017 15:40
@alexeagle
Copy link
Contributor

g3 is on TS 2.5 now, so I'll send a PR to update Angular also

@IgorMinar
Copy link
Contributor

IgorMinar commented Nov 1, 2017 via email

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: packaging Issues related to Angular's creation of npm packages cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Typescript peerDependency to be only the tested and verified minor version(s) of typescript
5 participants